Repository navigation
docs: align set_source duplicate_output wording with implementation - #130
Merged
Merged
Conversation
1. set_source on an existing group member now promotes it to source 2. remove the duplicate_output failure case from set_source description 3. keep duplicate_output only for add_output duplicate additions Log: No user-facing changes Influence: 1. Verify set_source on a current mirror promotes it to source on commit 2. Verify no operation_failed duplicate_output is emitted by set_source 3. Verify add_output on an existing member still reports duplicate_output docs: 对齐 set_source duplicate_output 措辞与实现 1. set_source 对本组已有成员现改为直接提升为源 2. 从 set_source 描述中移除 duplicate_output 失败情形 3. duplicate_output 仅保留给 add_output 的重复添加 Log: 无用户可见变化 Influence: 1. 验证对当前 mirror 调用 set_source 提交后将其提升为源 2. 验证 set_source 不再发送 operation_failed duplicate_output 3. 验证对已有成员调用 add_output 仍返回 duplicate_output PMS: TASK-395091
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the output-group protocol documentation to match implementation: set_source now directly promotes an existing member, including a current mirror, without emitting duplicate_output, while duplicate additions remain associated with add_output. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Groveer
approved these changes
Oct 26, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Groveer, wineee The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: No user-facing changes
Influence:
docs: 对齐 set_source duplicate_output 措辞与实现
Log: 无用户可见变化
Influence:
PMS: TASK-395091
Summary by Sourcery
Update output-group protocol documentation to accurately describe set_source promotion and error behavior.
Enhancements:
Documentation: