Skip to content

chore: replace Qt keywords with macros (QT_NO_KEYWORDS) - #534

Open
18202781743 wants to merge 1 commit into
masterfrom
agent/developer/dea1631977fa
Open

18202781743 wants to merge 1 commit into
masterfrom
agent/developer/dea1631977fa

Conversation

@18202781743

@18202781743 18202781743 commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Replace emit/signals:/slots: with Q_EMIT/Q_SIGNALS:/Q_SLOTS: to avoid naming conflicts with pure C++ or third-party libraries.

Also adds QT_NO_KEYWORDS compile definition in CMakeLists.txt and fixes SPDX copyright year ranges.

Related issue: DDE-499

Summary by Sourcery

Adopt Qt’s macro-based signal and slot declarations throughout the project and enable keyword suppression in the build configuration.

Enhancements:

  • Replace Qt signal and slot keywords with Q_EMIT, Q_SIGNALS, and Q_SLOTS across the project to support QT_NO_KEYWORDS and avoid naming conflicts with C++ and third-party libraries.

Build:

  • Enable the QT_NO_KEYWORDS compile definition for the main project and plugin targets.

Chores:

  • Update SPDX copyright year ranges across affected source files.

@deepin-ci-robot

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@18202781743
18202781743 force-pushed the agent/developer/dea1631977fa branch 2 times, most recently from d4774bd to da9520c Compare November 2, 2026 05:40
@18202781743
18202781743 marked this pull request as ready for review November 2, 2026 05:41
@sourcery-ai

sourcery-ai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Sorry @18202781743, your pull request is larger than the review limit of 150,000 diff characters

@18202781743
18202781743 force-pushed the agent/developer/dea1631977fa branch 3 times, most recently from b3fb987 to d7c19a8 Compare November 2, 2026 09:41
Replace emit/signals:/slots: with Q_EMIT/Q_SIGNALS:/Q_SLOTS: to avoid
naming conflicts with pure C++ or third-party libraries. Add QT_NO_KEYWORDS
compile definition after project() in CMakeLists.txt.

将 emit/signals:/slots: 替换为 Q_EMIT/Q_SIGNALS:/Q_SLOTS:,
避免纯 C++ 或第三方库引入时的命名冲突。在 CMakeLists.txt 中
添加 QT_NO_KEYWORDS 编译定义。

Log: 替换Qt关键字为宏形式并添加QT_NO_KEYWORDS编译定义
Influence: 无行为变更,仅关键字到宏的替换,解决第三方库命名冲突。
@18202781743
18202781743 force-pushed the agent/developer/dea1631977fa branch from d7c19a8 to bd3d0a6 Compare November 2, 2026 10:44
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 100 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 本次提交将 Qt 小写关键字(emit/signals/slots)统一替换为宏形式(Q_EMIT/Q_SIGNALS/Q_SLOTS), 并在多个 CMakeLists.txt 中添加 QT_NO_KEYWORDS 编译定义。变更属于纯机械式重构, 语法正确、逻辑无变化、性能无影响、无安全风险。版权年份同步更新合理。四维度均通过。

🔍 详细分析

1. 语法逻辑 ✅

评价: 语法正确,逻辑清晰 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


2. 代码质量 ✅

评价: 代码结构清晰,注释完整 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


3. 代码性能 ✅

评价: 性能良好,资源使用合理 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


4. 代码安全 🔒

评价: 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: []


💡 改进建议代码示例


本报告由 AI 代码审查工具自动生成

@18202781743
18202781743 requested review from BLumia and mhduiy November 3, 2026 02:15
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, BLumia

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants