Repository navigation
chore: update pkg-config include path for tray loader - #496
Merged
Merged
Conversation
18202781743
requested review from
BLumia,
mhduiy,
robertkill,
wjyrich and
yixinshark
August 21, 2026 03:18
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the pkg-config template for dde-tray-loader so that the advertised include directory matches the actual dde-dock header installation path, ensuring consumers can find the tray plugin development headers correctly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
BLumia
previously approved these changes
Aug 21, 2026
|
TAG Bot New tag: 2.0.40 |
|
TAG Bot New tag: 2.0.41 |
BLumia
approved these changes
Oct 12, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1. Change DTL_VERSION from "2.0.99" to "2.0.0" in CMakeLists.txt 2. This updates the project version definition used by the CMake build system 3. The version string is stored as a CACHE STRING and consumed elsewhere in the build to set the project version Influence: 1. Verify the CMake configuration completes without errors 2. Confirm the generated project version reflects 2.0.0 3. Check that dependent packaging scripts consuming DTL_VERSION still work correctly 4. Ensure no build artifacts or metadata still reference the previous version 2.0.99 chore: 将 DTL 版本更新为 2.0.0 1. 在 CMakeLists.txt 中将 DTL_VERSION 从 "2.0.99" 修改为 "2.0.0" 2. 该变更更新了 CMake 构建系统所使用的项目版本定义 3. 版本字符串以 CACHE STRING 形式存储，并在构建过程中被用于设置项目版本 Influence: 1. 验证 CMake 配置能够无错误完成 2. 确认生成的项目版本反映为 2.0.0 3. 检查依赖 DTL_VERSION 的打包脚本仍能正常工作 4. 确保没有构建产物或元数据仍引用旧版本 2.0.99
1. Change the includedir variable in dde-tray-loader.pc.in from `@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-tray-loader` to `@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-dock` 2. This corrects the actual installation directory where the tray plugin development headers are placed 3. Ensures pkg-config consumers can successfully locate and include the correct header files Influence: 1. Verify that `pkg-config --cflags dde-tray-loader` returns the updated include path pointing to `dde-dock` 2. Test building a sample program that uses the tray plugin headers via pkg-config 3. Ensure that consumer packages depending on this pc file can compile without header resolution errors chore: 更新托盘加载器的 pkg-config 包含路径 1. 将 dde-tray-loader.pc.in 中的 includedir 变量 从 `@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-tray-loader` 改为 `@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-dock` 2. 修正了托盘插件开发头文件实际安装目录的配置 3. 确保使用 pkg-config 的消费者能够正确定位并引用正确的头文件 Influence: 1. 验证 `pkg-config --cflags dde-tray-loader` 返回的包含路径指向 `dde- dock` 2. 测试通过 pkg-config 使用托盘插件头文件构建示例程序的过程 3. 确保依赖此 pc 文件的消费者包能够正常编译，无头文件解析错误
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： 语法正确，逻辑清晰。CMakeLists.txt 中 set(DTL_VERSION "2.0.0" CACHE STRING "Define project version") 语法正确，版本号格式合法。dde-tray-loader.pc.in 中 includedir=@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-dock 使用了标准的 CMake 变量替换语法，pkg-config 模板格式正确。includedir 路径变更与 CMakeLists.txt 第70行 install(FILES ${INTERFACES} DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/dde-dock) 保持一致，逻辑正确。 2. 代码质量 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： 代码结构清晰，注释完整。变更内容简洁明确，仅修改了两个配置值。Commit message 提供了详细的中英文双语说明，包括变更原因和影响分析。CMakeLists.txt 中的 systemd 配置部分有清晰的注释说明。变更风格与现有代码保持一致。 3. 代码性能 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： 性能良好，资源使用合理。本次变更仅为构建配置值的修改，不涉及任何算法、数据处理或资源分配逻辑，对运行时性能无任何影响。 4. 代码安全 🔒评价： 优秀 ✅ 通过
安全漏洞详情： 建议： 存在0个安全漏洞。本次变更不涉及用户输入处理、敏感信息存储、权限控制等安全相关逻辑。版本号更新和 include 路径修正均为静态配置值变更，不引入任何安全风险。 💡 改进建议代码示例// 本次变更无需改进，代码已符合规范
// CMakeLists.txt:
set(DTL_VERSION "2.0.0" CACHE STRING "Define project version")
// dde-tray-loader.pc.in:
includedir=@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-dock本报告由 AI 代码审查工具自动生成 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from
@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-tray-loaderto@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-dockdevelopment headers are placed
correct header files
Influence:
pkg-config --cflags dde-tray-loaderreturns the updatedinclude path pointing to
dde-dockpkg-config
without header resolution errors
chore: 更新托盘加载器的 pkg-config 包含路径
从
@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-tray-loader改为@CMAKE_INSTALL_FULL_INCLUDEDIR@/dde-dockInfluence:
pkg-config --cflags dde-tray-loader返回的包含路径指向dde- dockSummary by Sourcery
Fix the tray loader pkg-config metadata and align the project version with the intended release.
Bug Fixes:
Build: