Skip to content

fix(osd): add zh_HK and zh_TW translations for windoweffect OSD - #1774

Closed
wjyrich wants to merge 1 commit into
linuxdeepin:masterfrom
wjyrich:agent/pms-bug-bot/8d2fcbb18a37
Closed

wjyrich wants to merge 1 commit into
linuxdeepin:masterfrom
wjyrich:agent/pms-bug-bot/8d2fcbb18a37

Conversation

@wjyrich

@wjyrich wjyrich commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

fix(osd): add zh_HK and zh_TW translations for windoweffect OSD

  1. Root cause: zh_HK and zh_TW translation files for windoweffect OSD
    contained empty unfinished translations, causing English fallback
  2. Fix: fill in all 6 translation entries with proper Traditional Chinese
    for both zh_HK and zh_TW, add language attribute, remove unfinished type
  3. Impact: zh_HK and zh_TW users now see localized OSD text instead of
    English when toggling window effect modes via keyboard shortcut

Log: Fixed windoweffect OSD showing English under zh_HK and zh_TW locales

Influence:

  1. Test OSD display under zh_HK locale with Shift+Win+Tab
  2. Test OSD display under zh_TW locale with Shift+Win+Tab
  3. Verify zh_CN locale OSD display is unaffected

fix(osd): 补充窗口特效 OSD 繁体中文翻译

  1. 根因:窗口特效 OSD 的 zh_HK 和 zh_TW 翻译文件内容为空(unfinished),
    导致界面回退显示英文
  2. 方案:参照 zh_CN 翻译,为 zh_HK 和 zh_TW 填入全部 6 条繁体中文翻译,
    添加 language 属性,移除 type="unfinished" 标记
  3. 影响:zh_HK 和 zh_TW 用户通过快捷键切换窗口特效模式时可看到
    繁体中文 OSD 界面,不再显示英文

Log: 修复窗口特效 OSD 在繁体中文语言下显示英文的问题

Influence:

  1. 在 zh_HK 语言环境下测试 Shift+Win+Tab 快捷键 OSD 显示
  2. 在 zh_TW 语言环境下测试 Shift+Win+Tab 快捷键 OSD 显示
  3. 验证 zh_CN 语言环境下 OSD 显示不受影响

PMS: BUG-380303

Summary by Sourcery

Bug Fixes:

  • Provide complete Traditional Chinese translations for the window-effect OSD in both zh_HK and zh_TW locales, preventing fallback to English.

1. Root cause: zh_HK and zh_TW translation files for windoweffect OSD
   contained empty unfinished translations, causing English fallback
2. Fix: fill in all 6 translation entries with proper Traditional Chinese
   for both zh_HK and zh_TW, add language attribute, remove unfinished type
3. Impact: zh_HK and zh_TW users now see localized OSD text instead of
   English when toggling window effect modes via keyboard shortcut

Log: Fixed windoweffect OSD showing English under zh_HK and zh_TW locales

Influence:
1. Test OSD display under zh_HK locale with Shift+Win+Tab
2. Test OSD display under zh_TW locale with Shift+Win+Tab
3. Verify zh_CN locale OSD display is unaffected

fix(osd): 补充窗口特效 OSD 繁体中文翻译

1. 根因:窗口特效 OSD 的 zh_HK 和 zh_TW 翻译文件内容为空(unfinished),
   导致界面回退显示英文
2. 方案:参照 zh_CN 翻译,为 zh_HK 和 zh_TW 填入全部 6 条繁体中文翻译,
   添加 language 属性,移除 type="unfinished" 标记
3. 影响:zh_HK 和 zh_TW 用户通过快捷键切换窗口特效模式时可看到
   繁体中文 OSD 界面,不再显示英文

Log: 修复窗口特效 OSD 在繁体中文语言下显示英文的问题

Influence:
1. 在 zh_HK 语言环境下测试 Shift+Win+Tab 快捷键 OSD 显示
2. 在 zh_TW 语言环境下测试 Shift+Win+Tab 快捷键 OSD 显示
3. 验证 zh_CN 语言环境下 OSD 显示不受影响

PMS: BUG-380303
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR fixes English fallback for the window-effect OSD by completing all six Traditional Chinese translations and identifying both locale catalogs with their respective language attributes; review should verify the translated strings and test OSD behavior for zh_HK, zh_TW, and unchanged zh_CN behavior.

File-Level Changes

Change Details Files
Completed Traditional Chinese localization for the window-effect OSD in both Hong Kong and Taiwan locale catalogs.
  • Added zh_HK and zh_TW language attributes to the TS metadata.
  • Translated all six window-effect mode and description messages.
  • Removed type="unfinished" markers so the translations are eligible instead of falling back to English.
panels/notification/osd/windoweffect/translations/org.deepin.ds.osd.windoweffect_zh_HK.ts
panels/notification/osd/windoweffect/translations/org.deepin.ds.osd.windoweffect_zh_TW.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 100 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 本次提交为 windoweffect OSD 组件添加繁体中文(香港 zh_HK、台湾 zh_TW)翻译, 变更内容为两个 Qt .ts 翻译文件的文本填充。XML 结构规范,翻译内容完整, 无语法错误、无安全隐患、无性能影响。四维度均通过,代码审查通过。

🔍 详细分析

1. 语法逻辑 ✅

评价: 语法正确,逻辑清晰 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


2. 代码质量 ✅

评价: 代码结构清晰,注释完整 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


3. 代码性能 ✅

评价: 性能良好,资源使用合理 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


4. 代码安全 🔒

评价: 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: []


💡 改进建议代码示例

本次变更无需修复,代码质量良好。两个翻译文件已正确填充翻译内容。 如后续 zh_HK 与 zh_TW 在某些 UI 文案上存在地域差异,可分别调整对应翻译文本。

本报告由 AI 代码审查工具自动生成

@BLumia BLumia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本地使用 tx push -t -l zh_CN,zh_HK,zh_TW 推送中文文案

@wjyrich

wjyrich commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

本地使用 tx push -t -l zh_CN,zh_HK,zh_TW 推送中文文案

已完成。

@wjyrich
wjyrich requested a review from BLumia October 21, 2026 09:18
@BLumia

BLumia commented Oct 22, 2026

Copy link
Copy Markdown
Member

@wjyrich

wjyrich commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

@wjyrich wjyrich closed this Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants