Repository navigation
Conversation
1. Root cause: zh_HK and zh_TW translation files for windoweffect OSD contained empty unfinished translations, causing English fallback 2. Fix: fill in all 6 translation entries with proper Traditional Chinese for both zh_HK and zh_TW, add language attribute, remove unfinished type 3. Impact: zh_HK and zh_TW users now see localized OSD text instead of English when toggling window effect modes via keyboard shortcut Log: Fixed windoweffect OSD showing English under zh_HK and zh_TW locales Influence: 1. Test OSD display under zh_HK locale with Shift+Win+Tab 2. Test OSD display under zh_TW locale with Shift+Win+Tab 3. Verify zh_CN locale OSD display is unaffected fix(osd): 补充窗口特效 OSD 繁体中文翻译 1. 根因:窗口特效 OSD 的 zh_HK 和 zh_TW 翻译文件内容为空(unfinished), 导致界面回退显示英文 2. 方案:参照 zh_CN 翻译,为 zh_HK 和 zh_TW 填入全部 6 条繁体中文翻译, 添加 language 属性,移除 type="unfinished" 标记 3. 影响:zh_HK 和 zh_TW 用户通过快捷键切换窗口特效模式时可看到 繁体中文 OSD 界面,不再显示英文 Log: 修复窗口特效 OSD 在繁体中文语言下显示英文的问题 Influence: 1. 在 zh_HK 语言环境下测试 Shift+Win+Tab 快捷键 OSD 显示 2. 在 zh_TW 语言环境下测试 Shift+Win+Tab 快捷键 OSD 显示 3. 验证 zh_CN 语言环境下 OSD 显示不受影响 PMS: BUG-380303
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR fixes English fallback for the window-effect OSD by completing all six Traditional Chinese translations and identifying both locale catalogs with their respective language attributes; review should verify the translated strings and test OSD behavior for zh_HK, zh_TW, and unchanged zh_CN behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: [] 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: [] 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: [] 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: [] 💡 改进建议代码示例本次变更无需修复,代码质量良好。两个翻译文件已正确填充翻译内容。 如后续 zh_HK 与 zh_TW 在某些 UI 文案上存在地域差异,可分别调整对应翻译文本。本报告由 AI 代码审查工具自动生成 |
BLumia
left a comment
There was a problem hiding this comment.
本地使用 tx push -t -l zh_CN,zh_HK,zh_TW 推送中文文案
已完成。 |
fix(osd): add zh_HK and zh_TW translations for windoweffect OSD
contained empty unfinished translations, causing English fallback
for both zh_HK and zh_TW, add language attribute, remove unfinished type
English when toggling window effect modes via keyboard shortcut
Log: Fixed windoweffect OSD showing English under zh_HK and zh_TW locales
Influence:
fix(osd): 补充窗口特效 OSD 繁体中文翻译
导致界面回退显示英文
添加 language 属性,移除 type="unfinished" 标记
繁体中文 OSD 界面,不再显示英文
Log: 修复窗口特效 OSD 在繁体中文语言下显示英文的问题
Influence:
PMS: BUG-380303
Summary by Sourcery
Bug Fixes: