Repository navigation
fix: adjust quick panel icon/text color alpha and add hover state - #1770
MyLeeJiEun wants to merge 1 commit into
Conversation
1. Root cause: iconTextPalette in DockPalette.qml used 100% opacity for normal/normalDark states and lacked hovered/hoveredDark definitions, making colors non-compliant with system design spec 2. Fix: change normal/normalDark alpha from 1.0 to 0.7, add hovered and hoveredDark states with alpha=1.0; bind SettingButton textColor to iconTextPalette in PanelPluginPage.qml 3. Impact: quick panel icons and text now show 70% opacity by default and 100% on hover; SettingButton follows the same palette Log: quick panel icon/text color adjusted to 70% opacity with hover effect Influence: 1. Verify quick panel icon/text color in light mode (70% opacity) 2. Verify quick panel icon/text color in dark mode (70% opacity) 3. Verify hover state shows 100% opacity for icons and text 4. Verify SettingButton color matches other panel items fix: 调整快捷面板图标文字颜色透明度并补充hover状态 1. 根因:DockPalette.qml 中 iconTextPalette 的 normal/normalDark 状态 使用 100% 不透明度,且未定义 hovered/hoveredDark 状态,不符合系统 设计规范要求 2. 方案:将 normal/normalDark 的 alpha 从 1.0 改为 0.7,新增 hovered 和 hoveredDark 状态 alpha=1.0;PanelPluginPage.qml 中 SettingButton 绑定 textColor 到 iconTextPalette 3. 影响:快捷面板图标和文字默认显示 70% 不透明度,hover 时显示 100%; SettingButton 同步使用统一调色板 Log: 快捷面板图标文字颜色调整为70%透明度并增加hover效果 Influence: 1. 验证浅色模式下快捷面板图标文字颜色(70%不透明度) 2. 验证深色模式下快捷面板图标文字颜色(70%不透明度) 3. 验证hover状态下图标文字显示100%不透明度 4. 验证设置按钮颜色与其他面板项一致 PMS: BUG-314503
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MyLeeJiEun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe quick panel now uses a shared palette with 70% opacity in normal light/dark states and 100% opacity on hover, while SettingButton text is explicitly bound to that palette for consistent styling. Review should focus on theme-specific palette resolution, hover behavior, and visual consistency across quick-panel items. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Hi @MyLeeJiEun. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
TAG Bot New tag: 2.0.60 |
fix: adjust quick panel icon/text color alpha and add hover state
normal/normalDark states and lacked hovered/hoveredDark definitions,
making colors non-compliant with system design spec
hoveredDark states with alpha=1.0; bind SettingButton textColor to
iconTextPalette in PanelPluginPage.qml
and 100% on hover; SettingButton follows the same palette
Log: quick panel icon/text color adjusted to 70% opacity with hover effect
Influence:
fix: 调整快捷面板图标文字颜色透明度并补充hover状态
使用 100% 不透明度,且未定义 hovered/hoveredDark 状态,不符合系统
设计规范要求
和 hoveredDark 状态 alpha=1.0;PanelPluginPage.qml 中 SettingButton
绑定 textColor 到 iconTextPalette
SettingButton 同步使用统一调色板
Log: 快捷面板图标文字颜色调整为70%透明度并增加hover效果
Influence:
PMS: BUG-314503
Summary by Sourcery
Adjust quick panel colors to use reduced default opacity, full opacity on hover, and consistent setting-button styling.
Bug Fixes:
Enhancements: