Skip to content

fix: adjust quick panel icon/text color alpha and add hover state - #1770

Open
MyLeeJiEun wants to merge 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:agent/pms-bug-bot/3216f980fde5
Open

MyLeeJiEun wants to merge 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:agent/pms-bug-bot/3216f980fde5

Conversation

@MyLeeJiEun

@MyLeeJiEun MyLeeJiEun commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

fix: adjust quick panel icon/text color alpha and add hover state

  1. Root cause: iconTextPalette in DockPalette.qml used 100% opacity for
    normal/normalDark states and lacked hovered/hoveredDark definitions,
    making colors non-compliant with system design spec
  2. Fix: change normal/normalDark alpha from 1.0 to 0.7, add hovered and
    hoveredDark states with alpha=1.0; bind SettingButton textColor to
    iconTextPalette in PanelPluginPage.qml
  3. Impact: quick panel icons and text now show 70% opacity by default
    and 100% on hover; SettingButton follows the same palette

Log: quick panel icon/text color adjusted to 70% opacity with hover effect

Influence:

  1. Verify quick panel icon/text color in light mode (70% opacity)
  2. Verify quick panel icon/text color in dark mode (70% opacity)
  3. Verify hover state shows 100% opacity for icons and text
  4. Verify SettingButton color matches other panel items

fix: 调整快捷面板图标文字颜色透明度并补充hover状态

  1. 根因:DockPalette.qml 中 iconTextPalette 的 normal/normalDark 状态
    使用 100% 不透明度,且未定义 hovered/hoveredDark 状态,不符合系统
    设计规范要求
  2. 方案:将 normal/normalDark 的 alpha 从 1.0 改为 0.7,新增 hovered
    和 hoveredDark 状态 alpha=1.0;PanelPluginPage.qml 中 SettingButton
    绑定 textColor 到 iconTextPalette
  3. 影响:快捷面板图标和文字默认显示 70% 不透明度,hover 时显示 100%;
    SettingButton 同步使用统一调色板

Log: 快捷面板图标文字颜色调整为70%透明度并增加hover效果

Influence:

  1. 验证浅色模式下快捷面板图标文字颜色(70%不透明度)
  2. 验证深色模式下快捷面板图标文字颜色(70%不透明度)
  3. 验证hover状态下图标文字显示100%不透明度
  4. 验证设置按钮颜色与其他面板项一致

PMS: BUG-314503

Summary by Sourcery

Adjust quick panel colors to use reduced default opacity, full opacity on hover, and consistent setting-button styling.

Bug Fixes:

  • Align quick panel icon and text opacity with the system design specification, including full-opacity hover states in light and dark themes.

Enhancements:

  • Apply the shared dock icon/text palette to quick panel setting buttons for consistent coloring.

1. Root cause: iconTextPalette in DockPalette.qml used 100% opacity for
   normal/normalDark states and lacked hovered/hoveredDark definitions,
   making colors non-compliant with system design spec
2. Fix: change normal/normalDark alpha from 1.0 to 0.7, add hovered and
   hoveredDark states with alpha=1.0; bind SettingButton textColor to
   iconTextPalette in PanelPluginPage.qml
3. Impact: quick panel icons and text now show 70% opacity by default
   and 100% on hover; SettingButton follows the same palette

Log: quick panel icon/text color adjusted to 70% opacity with hover effect

Influence:
1. Verify quick panel icon/text color in light mode (70% opacity)
2. Verify quick panel icon/text color in dark mode (70% opacity)
3. Verify hover state shows 100% opacity for icons and text
4. Verify SettingButton color matches other panel items

fix: 调整快捷面板图标文字颜色透明度并补充hover状态

1. 根因:DockPalette.qml 中 iconTextPalette 的 normal/normalDark 状态
   使用 100% 不透明度,且未定义 hovered/hoveredDark 状态,不符合系统
   设计规范要求
2. 方案:将 normal/normalDark 的 alpha 从 1.0 改为 0.7,新增 hovered
   和 hoveredDark 状态 alpha=1.0;PanelPluginPage.qml 中 SettingButton
   绑定 textColor 到 iconTextPalette
3. 影响:快捷面板图标和文字默认显示 70% 不透明度,hover 时显示 100%;
   SettingButton 同步使用统一调色板

Log: 快捷面板图标文字颜色调整为70%透明度并增加hover效果

Influence:
1. 验证浅色模式下快捷面板图标文字颜色(70%不透明度)
2. 验证深色模式下快捷面板图标文字颜色(70%不透明度)
3. 验证hover状态下图标文字显示100%不透明度
4. 验证设置按钮颜色与其他面板项一致

PMS: BUG-314503
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MyLeeJiEun

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Oct 20, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The quick panel now uses a shared palette with 70% opacity in normal light/dark states and 100% opacity on hover, while SettingButton text is explicitly bound to that palette for consistent styling. Review should focus on theme-specific palette resolution, hover behavior, and visual consistency across quick-panel items.

File-Level Changes

Change Details Files
Align quick-panel icon and text colors with the design-spec opacity and hover states.
  • Reduce light and dark normal-state alpha to 70%.
  • Add opaque light and dark hovered states.
  • Verify palette state selection works for both themes and hover interactions.
panels/dock/DockPalette.qml
Apply the shared icon/text palette to quick-panel setting buttons.
  • Import the dock palette module.
  • Bind SettingButton textColor to DockPalette.iconTextPalette.
  • Confirm the new palette does not conflict with the existing window-text color binding or icon styling.
panels/dock/tray/quickpanel/PanelPluginPage.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

Hi @MyLeeJiEun. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-bot

deepin-bot Bot commented Oct 20, 2026

Copy link
Copy Markdown

TAG Bot

New tag: 2.0.60
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants