Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ org.deepin.dde.keybinding.shortcut.music,\
org.deepin.dde.keybinding.shortcut.numlock,\
org.deepin.dde.keybinding.shortcut.pictures,\
org.deepin.dde.keybinding.shortcut.power,\
org.deepin.dde.keybinding.shortcut.screensaver,\

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · Lock requests fail silently

When the X11 session manager is unavailable or rejects RequestLock, PowerController::systemAway() neither warns when the X11 session-manager interface is invalid nor checks the RequestLock reply, so the Screensaver key does nothing without an actionable error.

Check the X11 call result and log a warning when the interface is unavailable or the request fails.

Prompt for AI agents
In `src/plugin-qt/shortcut/configs/org.deepin.dde.keybinding.ini` at line 33:

**Lock requests fail silently**

When the X11 session manager is unavailable or rejects `RequestLock`, `PowerController::systemAway()` neither warns when the X11 session-manager interface is invalid nor checks the `RequestLock` reply, so the Screensaver key does nothing without an actionable error.

Check the X11 call result and log a warning when the interface is unavailable or the request fails.

org.deepin.dde.keybinding.shortcut.sleep,\
org.deepin.dde.keybinding.shortcut.speechtotext,\
org.deepin.dde.keybinding.shortcut.suspend,\
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
{
"magic": "dsg.config.meta",
"version": "1.0",
"contents": {
"appId": {
"value": "org.deepin.dde.keybinding",
"serial": 0,
"flags": [],
"name": "appId",
"name[zh_CN]": "提供快捷键应用Id",
"description": "provide shortcut app id",
"permissions": "",
"visibility": "private"
},
"displayName": {
"value": "Screen Saver",
"serial": 0,
"flags": [],
"name": "displayName",
"name[zh_CN]": "锁屏",
"description": "锁屏快捷键",
"permissions": "",
"visibility": "private"
},
"hotkeys": {
"value": [
"Screensaver"
],
"serial": 0,
"flags": [],
"name": "hotkeys",
"name[zh_CN]": "快捷键组合",
"description": "快捷键组合",
"permissions": "",
"visibility": "private"
},
"triggerType": {
"value": 1,
"serial": 0,
"flags": [],
"name": "triggerType",
"name[zh_CN]": "快捷键触发动作类型",
"description": "appId类型",
"permissions": "",
"visibility": "private"
},
"triggerValue": {
"value": [
"/usr/bin/dde-shortcut-tool",
"power",
"system-away"
],
"serial": 0,
"flags": [],
"name": "triggerValue",
"name[zh_CN]": "快捷键触发动作",
"description": "触发动作",
"permissions": "",
"visibility": "private"
},
"category": {
"value": "System",
"serial": 1,
"flags": [],
"name": "category",
"name[zh_CN]": "快捷键类别(System)",
"description": "System shortcut category",
"permissions": "",
"visibility": "private"
},
"enabled": {
"value": true,
"serial": 0,
"flags": [],
"name": "enabled",
"name[zh_CN]": "使能",
"description": "是否启用快捷键",
"permissions": "",
"visibility": "private"
},
"modifiable": {
"value": false,
"serial": 0,
"flags": [],
"name": "modifiable",
"name[zh_CN]": "能否修改快捷键",
"description": "不能修改快捷键",
"permissions": "",
"visibility": "private"
}
}
}
Loading