[yixinshark]

Summary

• Mail shortcut no longer runs bare xdg-email via dde-am -c; it now uses dde-shortcut-tool launch mime x-scheme-handler/mailto (serial 0->1), same pattern as audiomedia/music/pictures/video.
• Root cause: xdg-email is a short-lived wrapper; once it exits, systemd kills the transient cgroup children (default KillMode=control-group), so the real mail client never stays up.

Test plan

• python3 -m json.tool validates the edited shortcut json.
• On test machine with default mailto=cmclient.desktop: direct dde-shortcut-tool launch mime x-scheme-handler/mailto opens cmclient and it survives.
• Via shortcut-equivalent path dde-am -c /usr/bin/dde-shortcut-tool -- launch mime x-scheme-handler/mailto: cmclient stays running; transient unit exits cleanly with no Child cmclient killed TERM. Before the fix, dde-am -c /usr/bin/xdg-email showed exactly that kill in journal and no visible client.

PMS

Pms: BUG-378941

Summary by Sourcery

Bug Fixes:

• Launch the default mail client through the MIME handler so it remains running when invoked from the mail shortcut.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The mail shortcut now launches the system default mail client through dde-shortcut-tool's mailto MIME handler, avoiding systemd transient-cgroup cleanup of clients started by xdg-email.

File-Level Changes

Change	Details	Files
Route the mail shortcut through the MIME handler launcher instead of the short-lived xdg-email wrapper.	Replace the mail command with dde-shortcut-tool MIME launch for x-scheme-handler/mailto. Align the invocation and serial behavior with the existing audio, music, pictures, and video shortcuts. Preserve the shortcut configuration as valid JSON.	src/plugin-qt/shortcut/configs/org.deepin.dde.keybinding.shortcut.mail/org.deepin.shortcut.json

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

[deepin-ci-robot]

deepin pr auto review

🤖 AI 代码审查报告

总体评分： 100 分 (通过阈值: 70分)

---

📊 总体评价

项目	结果
审查结论	代码审查通过
评分详情	本次变更为邮件快捷键配置修复，将 triggerValue 从 xdg-email 改为 dde-shortcut-tool launch mime 方式，与现有 music/pictures/video 快捷键配置模式一致。修改正确解决了 systemd transient service 导致邮件客户端被杀的问题，未引入安全漏洞。

---

🔍 详细分析

1. 语法逻辑 ✅

评价： 优秀 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： []

---

2. 代码质量 ✅

评价： 优秀 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： []

---

3. 代码性能 ✅

评价： 优秀 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： []

---

4. 代码安全 🔒

评价： 优秀 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情：
✅ 未发现安全漏洞

建议： []

---

💡 改进建议代码示例

// 暂无代码示例

---

本报告由 AI 代码审查工具自动生成

[deepin-bot]

TAG Bot

New tag: 1.0.45
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #189

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, yixinshark

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yixinshark]

/forcemerge

[deepin-bot]

This pr force merged! (status: blocked)