Repository navigation
fix: 修复深色模式下启动器文字颜色不反色 - #828
Merged
Merged
Conversation
wjyrich
marked this pull request as draft
October 21, 2026 03:40
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe launcher’s windowed-mode QML window now binds DWindow.themeType to the system DTK theme, aligning its text colors with dark mode; fullscreen behavior and imports remain unchanged. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
1. Add DWindow.themeType: D.DTK.themeType to windowedModeLauncher Window 2. Fix dark mode text color not inverting in windowed launcher mode 3. Fullscreen mode already had themeType set, windowed mode was missing Log: Windowed launcher now follows system dark/light theme Influence: 1. Test launcher text color in dark mode (windowed mode) 2. Test launcher text color in light mode (windowed mode) 3. Verify theme switches correctly when toggling system theme fix: 设置窗口模式启动器的 DWindow 主题类型 1. 在 windowedModeLauncher Window 中添加 DWindow.themeType: D.DTK.themeType 2. 修复深色模式下窗口模式启动器文字颜色不反色的问题 3. 全屏模式已设置 themeType，窗口模式之前遗漏 Log: 窗口模式启动器现在跟随系统深色/浅色主题 Influence: 1. 测试深色模式下启动器文字颜色（窗口模式） 2. 测试浅色模式下启动器文字颜色（窗口模式） 3. 验证切换系统主题时文字颜色正确切换 PMS: BUG-380337
wjyrich
force-pushed
the
agent/bot/fea04f6d0655
branch
from
October 21, 2026 03:44
788e216 to
15e7456
Compare
wjyrich
marked this pull request as ready for review
October 21, 2026 06:25
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价： 语法正确，逻辑清晰 ✅ 通过 潜在问题： 建议： [] 2. 代码质量 ✅评价： 代码结构清晰，注释完整 ✅ 通过 潜在问题： 建议： [] 3. 代码性能 ✅评价： 性能良好，资源使用合理 ✅ 通过 潜在问题： 建议： [] 4. 代码安全 🔒评价： 存在0个安全漏洞 ✅ 通过
安全漏洞详情： 建议： [] 💡 改进建议代码示例// 当前修复已正确，无需额外修改。 // DWindow.themeType: D.DTK.themeType 已正确绑定窗口主题到 DTK 平台主题。本报告由 AI 代码审查工具自动生成 |
BLumia
approved these changes
Oct 21, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: blocked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
In dark mode, all text in the launcher appears black because the windowed mode launcher (
windowedModeLauncherWindow block inlauncheritem.qml) does not setDWindow.themeType. Without this, the DTK window is unaware of the system dark theme, so text colors don't invert.The fullscreen mode launcher already sets
DWindow.themeType(line 230), but the windowed mode was missing this setting.Fix
Added
DWindow.themeType: D.DTK.themeTypeaftercolor: "transparent"in thewindowedModeLauncherWindow block. This makes the windowed launcher follow the system theme type, so text colors invert correctly in dark mode.Both
DWindowandDimports already exist in the file, so no additional imports are needed.Related
Summary by Sourcery
Bug Fixes: