Skip to content

fix: 适配 Treeland 个性化协议变更 - #825

Open
18202781743 wants to merge 1 commit into
masterfrom
agent/developer/launchpad
Open

18202781743 wants to merge 1 commit into
masterfrom
agent/developer/launchpad

Conversation

@18202781743

@18202781743 18202781743 commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

适配 Treeland 个性化协议变更

关联

改动内容

  • 删除整个 src/treelandintegration/ 目录(旧 personalization-manager-v1 协议相关代码)
  • 更新顶层 CMakeLists.txt:移除 add_subdirectory(src/treelandintegration) 和 treeland-integration target 链接
  • personalizeWindow() 原本已是空操作,删除后不影响现有功能

Summary by Sourcery

Remove the deprecated Treeland personalization-manager-v1 integration and its project wiring.

Bug Fixes:

  • Remove obsolete Treeland personalization integration to align with the updated personalization protocol.

Build:

  • Remove the legacy Treeland integration target and its build configuration.

@18202781743
18202781743 marked this pull request as draft October 16, 2026 07:45
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

本 PR 删除旧版 Treeland personalization-manager-v1 协议的全部实现、D-Bus 定义及构建目标,并同步清理顶层 CMake 配置;由于 personalizeWindow() 原本为空操作,预期不影响现有功能。

File-Level Changes

Change Details Files
移除旧版 Treeland personalization-manager-v1 集成及其实现文件,使项目不再依赖已废弃的个性化协议。
  • 删除 Treeland 个性化管理器、窗口适配器及 D-Bus 协议 XML。
src/treelandintegration/CMakeLists.txt
src/treelandintegration/personalizationmanager.cpp
src/treelandintegration/personalizationmanager.h
src/treelandintegration/personalizationwindow.cpp
src/treelandintegration/personalizationwindow.h
src/treelandintegration/treeland-personalization-manager-v1.xml
更新构建配置以完全移除 Treeland 集成组件。
  • 删除 Treeland 集成子目录配置。
  • 移除 launchpadcommon 对 treeland-integration target 的链接。
CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@18202781743
18202781743 force-pushed the agent/developer/launchpad branch from e1ba330 to 8a8233b Compare October 20, 2026 02:23
1. Delete entire src/treelandintegration/ directory
2. Remove add_subdirectory and target link from CMakeLists.txt
3. personalizeWindow() was already a no-op, no functional impact

Log: Remove deprecated treeland personalization integration from dde-launchpad
Influence:
1. Verify dde-launchpad builds successfully without treelandintegration
2. Verify launcher window launch and display work normally

fix: 移除已废弃的 treeland 个性化集成

1. 删除整个 src/treelandintegration/ 目录
2. 移除 CMakeLists.txt 中的 add_subdirectory 和 target 链接
3. personalizeWindow() 原已是空操作,无功能影响

Log: 移除 dde-launchpad 中已废弃的 treeland 个性化集成
Influence:
1. 验证 dde-launchpad 在无 treelandintegration 时构建成功
2. 验证启动器窗口启动和显示正常

PMS: TASK-396717
@18202781743
18202781743 force-pushed the agent/developer/launchpad branch from 8a8233b to 98c4111 Compare October 20, 2026 05:03
@18202781743
18202781743 marked this pull request as ready for review October 20, 2026 05:03
@18202781743
18202781743 requested a review from BLumia October 20, 2026 05:03

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-bot

deepin-bot Bot commented Oct 20, 2026

Copy link
Copy Markdown

TAG Bot

New tag: 2.0.51
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants