[mhduiy]

问题

PMS: BUG-379697、BUG-379687、BUG-379685

控制中心切换系统语言后，locale 正常生成、界面语言正常切换，但本应自动安装的语言支持包（字体、拼写词典、应用语言包等）从不安装，org.deepin.dde.Lastore1 收不到 InstallPackage；开始时的通知也不会出现"安装"那一条。另外 GetLanguageSupportPackages 查询很慢，可能超过调用方超时。

原因

1. 安装判断写反：getInstallLangSupportPackages() 调用 ByLocale(locale, false)，false 表示只返回尚未安装的包，但 setLocale() 却写成 isInstalled := len(pkg) != 0，于是有包要装时被当成"已安装"而跳过，没有缺包时才进入安装流程（装一个空列表）。
2. 联网判断永远为"未联网"：isNetworkEnable() 读取会话总线 org.deepin.dde.Network1 的 State，而 dde-network-core 2.0 中该对象是兼容层，State 固定返回 0，因此即使已联网也判定为断网，进一步挡住安装。
3. 查询逐包起进程：dde-api 的 language_support 对每个候选包各启动一次 dpkg-query / apt-cache policy；apt-cache 每次启动都要加载整个包缓存并计算 pin，候选包有几十个时耗时累积到数十秒。

修改

langselector1/locale.go：

• 改用 needsInstall := len(pkg) != 0，有缺包且联网才安装。
• isNetworkEnable() 改为读取系统总线上 org.freedesktop.NetworkManager 的 State 属性（经 go-dbus-factory 的 system 绑定），不再依赖会话 org.deepin.dde.Network1 兼容层。
• 联网条件收紧为 NM_STATE_CONNECTED_GLOBAL (70)：仅本地/站点连通无法访问软件源。
• 没有缺包时也发送"正在切换语言"通知；installLangSupportPackages() 复用 getInstallLangSupportPackages()，避免重复查询。

查询侧的批量改造在 dde-api：linuxdeepin/dde-api#205。

验证

• go test ./langselector1 通过。
• 隔离验证 setLocale() 的四种组合（联网/断网 × 有缺包/无缺包）：只有"联网且缺包"会发起安装，断网仍能正常完成语言切换。
• 实测 NetworkManager State 返回 70，修改后的读取函数判定为已连接；0~60 判定为未连通。
• 真实环境下切换语言功能由提交者验证通过（控制中心切换 + 自动补装包）。

dde-api 的批量查询修复（linuxdeepin/dde-api#205）需一并合入，否则查询仍会逐包起进程；打包时 dde-daemon 依赖已安装的 dde-api-dev 源码，需要先更新 dde-api。

[sourcery-ai]

Reviewer's Guide

Fixes language support installation by correctly detecting missing packages, using system-bus NetworkManager global connectivity, and preserving start notifications for all language switches; the separate dde-api batch-query change must also be integrated to address slow package discovery.

Sequence diagram for language switching and support package installation

sequenceDiagram
    participant User
    participant LangSelector
    participant LanguageSupport
    participant NetworkManager
    participant Lastore
    participant Notifications

    User->>LangSelector: setLocale(locale)
    LangSelector->>LanguageSupport: ByLocale(locale, false)
    LanguageSupport-->>LangSelector: missing packages
    LangSelector->>NetworkManager: PropState().Get(0)
    NetworkManager-->>LangSelector: State
    LangSelector->>Notifications: sendNotify(start notification)
    LangSelector->>LangSelector: generate locale
    alt missing packages and State == 70
        LangSelector->>LanguageSupport: ByLocale(locale, false)
        LanguageSupport-->>LangSelector: packages to install
        LangSelector->>Lastore: InstallPackage(packages)
    end

Loading

File-Level Changes

Change	Details	Files
Correct language-support package installation decisions and notifications.	Treat nonempty missing-package results as requiring installation. Install only when NetworkManager reports CONNECTED_GLOBAL. Always send the language-switch start notification, selecting the install variant only when applicable. Reuse the package lookup during installation to avoid duplicate lookup logic.	langselector1/locale.go
Switch connectivity detection to the authoritative system-wide NetworkManager API.	Replace the session-bus dde-network compatibility object with the system-bus NetworkManager manager binding. Require state 70 rather than accepting partial local or site connectivity.	langselector1/locale.go
Document the language-selector fixes in the unreleased changelog.	Record package installation, connectivity gating, and notification behavior changes.	CHANGELOG.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've found 1 issue

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="langselector1/locale.go" line_range="464" />
<code_context>
-		} else {
-			sendNotify(localeIconStart, "", notifyTxtStart)
-		}
+	if needsInstall && networkEnabled {
+		sendNotify(localeIconStart, "", notifyTxtStartWithInstall)
+	} else {
</code_context>
<issue_to_address>
**Failed installs appear successful**

When lastore rejects the install request or reports a failed package job, `installLangSupportPackages` returns an error, but `setLocale` only logs it before sending the finished notification and marking the locale change complete. Users see success while the support packages remain absent.

Propagate the installation error so `setLocale` does not report the locale change as successfully completed.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

[deepin-ci-robot]

deepin pr auto review

🤖 AI 代码审查报告

总体评分： 75 分 (通过阈值: 70分)

---

📊 总体评价

项目	结果
审查结论	代码审查通过
评分详情	总体评分 75 分，大于 70 分通过阈值。代码修复了语言包安装的逻辑缺陷，但存在资源泄漏问题需要关注。

---

🔍 详细分析

1. 语法逻辑 ❌

评价： 需改进 ❌ 不通过

潜在问题：

1. langselector1/locale.go:588 - getInstallLangSupportPackages() 函数中移除了 ls.Destroy() 调用，导致 LanguageSupport 对象资源泄漏。该函数仍创建 ls 对象但不再销毁，每次调用都会泄漏资源

建议： 在 getInstallLangSupportPackages() 函数中使用 defer ls.Destroy() 确保资源释放，或恢复原来的显式 Destroy 调用

---

2. 代码质量 ✅

评价： 优秀 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： 代码质量良好，变量命名从 isInstalled 改为 needsInstall 更准确，installLangSupportPackages 复用 getInstallLangSupportPackages 消除了重复代码

---

3. 代码性能 ✅

评价： 优秀 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： 性能良好，使用 SystemBus 访问 NetworkManager 更合理，网络状态检查 state==70(NM_STATE_CONNECTED_GLOBAL) 更精确

---

4. 代码安全 🔒

评价： 优秀 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情：
✅ 未发现安全漏洞

建议： 无安全漏洞，代码安全合规

---

💡 改进建议代码示例

func (lang *LangSelector) getInstallLangSupportPackages(locale string) ([]string, error) {
    ls, err := language_support.NewLanguageSupport()
    if err != nil {
        return nil, dbusutil.ToError(err)
    }
    defer ls.Destroy() // 确保资源释放
    return ls.ByLocale(locale, false), nil
}

---

本报告由 AI 代码审查工具自动生成

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, mhduiy

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mhduiy]

deepin pr auto review

🤖 AI 代码审查报告

总体评分： 75 分 (通过阈值: 70分)

### 📊 总体评价 项目 结果 **审查结论** 代码审查通过 **评分详情** 总体评分 75 分，大于 70 分通过阈值。代码修复了语言包安装的逻辑缺陷，但存在资源泄漏问题需要关注。 ### 🔍 详细分析 #### 1. 语法逻辑 ❌

评价： 需改进 ❌ 不通过

潜在问题：

1. `langselector1/locale.go:588` - getInstallLangSupportPackages() 函数中移除了 ls.Destroy() 调用，导致 LanguageSupport 对象资源泄漏。该函数仍创建 ls 对象但不再销毁，每次调用都会泄漏资源

建议： 在 getInstallLangSupportPackages() 函数中使用 defer ls.Destroy() 确保资源释放，或恢复原来的显式 Destroy 调用

2. 代码质量 ✅

评价： 优秀 ✅ 通过

潜在问题： ✅ 未发现明显问题

建议： 代码质量良好，变量命名从 isInstalled 改为 needsInstall 更准确，installLangSupportPackages 复用 getInstallLangSupportPackages 消除了重复代码

3. 代码性能 ✅

评价： 优秀 ✅ 通过

潜在问题： ✅ 未发现明显问题

建议： 性能良好，使用 SystemBus 访问 NetworkManager 更合理，网络状态检查 state==70(NM_STATE_CONNECTED_GLOBAL) 更精确

4. 代码安全 🔒

评价： 优秀 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情： ✅ 未发现安全漏洞

建议： 无安全漏洞，代码安全合规

💡 改进建议代码示例

func (lang *LangSelector) getInstallLangSupportPackages(locale string) ([]string, error) {
    ls, err := language_support.NewLanguageSupport()
    if err != nil {
        return nil, dbusutil.ToError(err)
    }
    defer ls.Destroy() // 确保资源释放
    return ls.ByLocale(locale, false), nil
}

本报告由 AI 代码审查工具自动生成

Destroy 本身是空实现，调用也是空调用