[mhduiy]

Removes the hardcoded QT_LOGGING_RULES="*.debug=false" from the user systemd unit of dde-application-manager.

• Debug output now follows the session's Qt logging configuration (qtlogging.ini / QT_LOGGING_RULES from the environment) instead of being force-disabled by the unit
• Debug logs can be enabled without editing the installed unit
• No other unit in the repo sets logging rules; behavior is otherwise unchanged

PMS: TASK-396623

Summary by Sourcery

Enhancements:

• Allow the application manager to follow the session's Qt logging configuration instead of forcing debug logging off in its user systemd unit.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the user systemd unit’s hardcoded Qt logging override, allowing qtlogging.ini or the session’s QT_LOGGING_RULES environment setting to control debug output without modifying the installed unit.

File-Level Changes

Change	Details	Files
Delegate Qt logging behavior to the session configuration instead of forcing it off in the user service unit.	Remove the hardcoded QT_LOGGING_RULES="*.debug=false" environment setting. Preserve the rest of the systemd unit behavior unchanged.	misc/systemd/user/org.desktopspec.ApplicationManager1.service.in

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, robertkill

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deepin-ci-robot]

deepin pr auto review

🤖 AI 代码审查报告

总体评分： 100 分 (通过阈值: 70分)

---

📊 总体评价

项目	结果
审查结论	代码审查通过
评分详情	总体评分 100 分，大于 70 分通过阈值，代码质量符合要求。本次变更从 systemd 用户服务单元中移除了硬编码的 QT_LOGGING_RULES 环境变量，变更内容简洁明确，无安全漏洞，无语法逻辑问题。

---

🔍 详细分析

1. 语法逻辑 ✅

评价： 优秀 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： 无需修改，systemd 单元文件语法正确，移除 Environment 指令后服务单元仍然有效。

---

2. 代码质量 ✅

评价： 优秀 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： 无需修改，变更简洁明了，commit message 清晰描述了变更目的，PR 描述提供了充分的上下文。

---

3. 代码性能 ✅

评价： 优秀 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： 无需修改，移除环境变量对性能无影响。

---

4. 代码安全 🔒

评价： 优秀 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情：
✅ 未发现安全漏洞

建议： 无需修改，移除硬编码的日志规则不会引入安全漏洞。调试日志的开启与关闭应由会话级配置控制，而非硬编码在 systemd 单元中。

---

💡 改进建议代码示例

# 移除前（misc/systemd/user/org.desktopspec.ApplicationManager1.service.in）
[Service]
Type=dbus
BusName=org.desktopspec.ApplicationManager1
ExecStart=@CMAKE_INSTALL_FULL_BINDIR@/dde-application-manager
Environment=QT_LOGGING_RULES="*.debug=false"  # <- 被移除的行
Slice=session.slice
Restart=always
RestartSec=500ms

# 移除后
[Service]
Type=dbus
BusName=org.desktopspec.ApplicationManager1
ExecStart=@CMAKE_INSTALL_FULL_BINDIR@/dde-application-manager
# Environment 行已移除，调试日志现在遵循会话级 Qt 日志配置
Slice=session.slice
Restart=always
RestartSec=500ms

---

本报告由 AI 代码审查工具自动生成

[mhduiy]

/forcemerge

[deepin-bot]

This pr force merged! (status: blocked)