Repository navigation
chore: add xujin177 to dde-maintainer team - #812
Conversation
add xujin177 to dde-maintainer
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Hi @xujin177. Thanks for your PR. 😃 |
|
Hi @xujin177. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="teams.yaml" line_range="37" />
<code_context>
- Ivy233
- ut005973
- 52cyb
+ - xujin177
repositories_permissions:
triage:
</code_context>
<issue_to_address>
**Earlier run removes new member**
When a workflow run for an earlier commit is still in flight and applies its team update after the run for this change, the older workflow reconciles membership from its checked-out `teams.yaml` and removes `xujin177`, leaving the member absent despite this change.
Serialize the team-manager workflow runs with a shared concurrency group so an older config cannot apply after a newer one.
</issue_to_address>| - Ivy233 | ||
| - ut005973 | ||
| - 52cyb | ||
| - xujin177 |
There was a problem hiding this comment.
🟡 Medium · Earlier run removes new member
When a workflow run for an earlier commit is still in flight and applies its team update after the run for this change, the older workflow reconciles membership from its checked-out teams.yaml and removes xujin177, leaving the member absent despite this change.
Serialize the team-manager workflow runs with a shared concurrency group so an older config cannot apply after a newer one.
Prompt for AI agents
In `teams.yaml` at line 37:
**Earlier run removes new member**
When a workflow run for an earlier commit is still in flight and applies its team update after the run for this change, the older workflow reconciles membership from its checked-out `teams.yaml` and removes `xujin177`, leaving the member absent despite this change.
Serialize the team-manager workflow runs with a shared concurrency group so an older config cannot apply after a newer one.|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, xujin177 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
add xujin177 to dde-maintainer
Summary by Sourcery
Chores: