Repository navigation
Config file mode - #4367
Open
igaw wants to merge 2 commits into
Open
Config file mode#4367igaw wants to merge 2 commits into
igaw wants to merge 2 commits into
Conversation
igaw
commented
Nov 2, 2026
igaw
commented
Collaborator
- libnvme/config: don't make nvme-fabrics.conf world-readable
- doc: describe the INI configuration in the fabrics man pages
The emitter wrote every file with mode 0644. nvme-fabrics.conf can hold KX-HMAC-CHAP secrets and TLS PSKs, so nvme config create and nvme config convert made them readable by every user. As the file is replaced, a mode of 0600 set by the admin was reset to 0644 as well. Create a new file with mode 0600, and keep the mode of an existing one. Signed-off-by: Daniel Wagner <wagi@monom.org>
The man pages of discover, connect-all and connect still describe the configuration of nvme-cli 2.x: discovery.conf, and --config naming a JSON file. Since 3.0, they read nvme-fabrics.conf, and nvme connect reads a file only with --config. nvme-config-convert(1) says that a converted file is renamed, but it is kept and a symlink marks it. Describe what the commands do, and the mode of the file nvme config create writes. Signed-off-by: Daniel Wagner <wagi@monom.org>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.