Expose splice negotiation events over gRPC - #265
Open
elnafateh wants to merge 1 commit into
Open
Conversation
|
👋 Thanks for assigning @benthecarman as a reviewer! |
benthecarman
self-requested a review
August 31, 2026 10:40
elnafateh
force-pushed
the
expose-splice-events
branch
from
August 31, 2026 11:36
96f209d to
eb88dc0
Compare
benthecarman
requested changes
Aug 31, 2026
benthecarman
left a comment
benthecarman
left a comment
Collaborator
There was a problem hiding this comment.
Can we add the new events in api-guide.md, otherwise looks good
elnafateh
force-pushed
the
expose-splice-events
branch
from
August 31, 2026 21:41
eb88dc0 to
4dc5ac7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #251.
EventEnvelopewas missingSpliceNegotiatedandSpliceNegotiationFailed, both currently silently dropped by the catch-all event arm. This adds them as newoneofvariants (tags 9, 10), following the same field-mapping pattern as the existingChannelStateChangedhandling.SpliceNegotiationFailedhas no test coverage. Reproducing it requires interrupting a live splice negotiation from outside the node at the exact moment negotiation is still pending, butLDKresolves the interactive-tx-construction phase of a splice in ~10ms over loopback, faster than any external call to this server (CLI or gRPC, ~60ms per call with TLS handshake) can land. ldk-node itself has no test coverage of this event either.