Bump LDK to 0.3-rc1 - #1077
Merged
Merged
Conversation
The 0.3-rc1 backports (rust-lightning #4937) include failing queued splice contributions on ChannelManager reload and force-close (rust-lightning #4918), which the upcoming splice tracking relies on: a contribution dropped by a restart now replays SpliceNegotiationFailed and DiscardFunding events instead of dying silently. Adjust for rc1 API changes: HTLCLocator split into inbound and outbound variants, and the async monitor reader dropped its _parallel suffix. bitcoin-payment-instructions pins LDK by rev and must move in lockstep; the previously pinned fork has no rev pinning rc1 yet, so the dependency moves to an equivalent fork rev (the same tree plus the LDK bump). Developed with assistance from Claude Code. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
👋 Thanks for assigning @benthecarman as a reviewer! |
benthecarman
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the pinned rust-lightning revision to
4219131b0, thev0.3-rc1tag. The rc1 backports (rust-lightning #4937) include failing queued splice contributions onChannelManagerreload and force-close (rust-lightning #4918): a splice contribution dropped by a restart now replaysSpliceNegotiationFailedandDiscardFundingevents instead of dying silently, which upcoming splice-tracking work relies on.API fallout is small:
HTLCLocatorsplit intoInboundHTLCLocator/OutboundHTLCLocator(both convert into our singleHTLCLocatorevent type), and the async channel-monitor reader dropped its_parallelsuffix. rc1 also changedEvent::SpliceNegotiationFailed::contributionfromOption<FundingContribution>toOption<FailedSpliceContribution>, but our handler doesn't consume that field, so no change was needed.bitcoin-payment-instructionspins LDK by git rev and must move in lockstep. No rev on the previously pinned fork pins rc1 yet, so the dependency moves to an equivalent fork rev (jkczyz/bitcoin-payment-instructions@c359b125— the same tree as the previous pin plus the LDK bump).One dev-only caveat: a
ChannelManagerwritten by v0.3-beta1 with a pending splice-failure event is unreadable by rc1, due to the TLV collision fix (rust-lightning879f640e7). No ldk-node release shipped beta1, so only development nodes that ran against beta1 are affected.Developed with assistance from Claude Code.