Repository navigation
Run the identifier web app checks in CI - #280
Merged
longsleep merged 1 commit intoOct 13, 2026
Merged
Conversation
The build job bundled the identifier web app but never ran its lint, type check or tests. Dependabot's grouped update libregraph#278 moved jsdom to 30.1.2, with which Vitest cannot start a single test file, and CI still reported success. build.yml now runs make -C identifier check, which is Biome, tsc and Vitest, after the Go lint and before the build, so a dependency update which breaks any of them turns the run red. The step needs no extra setup. The Vendor step already installs the web app dependencies, and since the test target generates the app icon it needs, check also works on a fresh checkout that was never built. It leaves no tracked file changed, so the clean check of the later Dist step is unaffected. From a clean worktree, after make -C identifier vendor, the check passes on master with 317 tests and leaves git status clean apart from the workflow. With jsdom 30.1.2 the same target fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build job bundles the identifier web app but never runs its lint, type check or tests. #278 showed the gap: its jsdom bump to 30.1.2 stops Vitest from starting a single test file, and CI still reported success.
A new step
Check identifierrunsmake -C identifier check(Biome, tsc, Vitest) after the Go lint and before the build, so an update which breaks them turns the run red. It needs no extra setup: the Vendor step already installs the web app dependencies, and the test target generates the app icon it needs. It leaves no tracked file changed, so the Dist step's clean check is unaffected.Tests
From a clean checkout, after
make -C identifier vendor,make -C identifier checkpasses onmaster(317 tests) and leaves the tree clean. With jsdom 30.1.2 the same target fails.