Repository navigation
ci: build version from pyproject - #120
Merged
everoddandeven merged 5 commits intoOct 30, 2026
Merged
Conversation
everoddandeven
changed the title
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
everoddandeven
force-pushed
the
build/version-from-pyproject
branch
from
October 30, 2026 01:52
43ed0c7 to
d92f9b0
Compare
CMakeLists.txt reads the version declared in pyproject.toml instead of repeating it, and passes it to py_monero_utils.cpp, which reports it from get_version(). The function moves out of the header, so a new version only rebuilds that file instead of every one that includes the header. test_get_version now checks that the compiled module reports the version of pyproject.toml. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The four debian/<codename> directories had the same files: only a blank line of the changelog differed. The distro is already taken from /etc/os-release for the name of the package, and the dependencies are computed by dpkg-shlibdeps at build time, so debian/DEBIAN is copied as it is. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
build.sh reads the version for the name of the package from pyproject.toml, and patches it in the control file as it already does for the architecture and the dependencies, so the template keeps a placeholder. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The build backend is scikit-build-core, declared in pyproject.toml, so pip never runs setup.py. It imports skbuild from scikit-build, which no build requires or installs, and it only repeated the version. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The release fails before it looks for the build runs when the tag is not the version of the tagged commit, instead of publishing a draft with packages named after another version. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
everoddandeven
force-pushed
the
build/version-from-pyproject
branch
from
October 30, 2026 04:52
d92f9b0 to
be4199a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.