Repository navigation
Read a * inside quotes as text, as Lucene's parser does, so "of sou*" is the phrase "of sou" (#439) - #440
Draft
jasperblues wants to merge 2 commits into
Draft
Read a * inside quotes as text, as Lucene's parser does, so "of sou*" is the phrase "of sou" (#439)#440jasperblues wants to merge 2 commits into
jasperblues wants to merge 2 commits into
Conversation
… is the phrase "of sou" (#439) Port of liberation-data/drivine4j#622 (drivine4j PR #632).
…r in a phrase is text (#439)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #439. Port of liberation-data/drivine4j#622 (drivine4j PR #632), as liberation-data/drivine#647 ports it. Not to merge until train 2026.11.2 is published, and not before drivine#647.
_term_of(drivine/backend/sql/text_query.py) read a quoted phrase ending in*,"of sou*", as a prefix phrase, so it matched "of soup". Lucene's classic parser, as Neo4j uses it, reads a*inside quotes as text, so Neo4j searches for the phrase "of sou". A term is now a prefix only when its token isn't quoted. Oracle Text follows:"graph pre*"becomes({graph pre}).Goldens: unchanged.
Tests
tests/integration/test_bm25.py, and its sync copy, on Neo4j, Postgres, Postgres indexed, SQLite and Oracle:"of sou*"finds nothing, and"of soup*"finds "a graph of soup".tests/unit/test_text_query.py:"of sou*",body:"of sou*","of sou\*","kiw*",sou*and+kiw*;"graph pre*","kiw*"andbody:"of sou*".Verification