Repository navigation
Mark the Postgres CALL…RETURN timing case as an xfail for #420, as the MERGE case is - #425
Merged
Merged
Conversation
…e MERGE case is drivine4j#609 found a second cause of #420: a CALL joins its one-row list to the node table for each row, and Postgres, taking the list for 100 rows, may scan every node for it. drivine-python CI now fails the sync case on Python 3.13 (36.8 s and 36.5 s over 20,000 rows). The mark is not strict, as the MERGE one isn't, and comes off with #420's fix.
This was referenced Nov 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #420.
CompiledWriteLoopTimeTest's Postgres CALL…RETURN case now fails CI reliably on Python 3.13. It took 36.8 s, then 36.5 s, over 20,000 rows against a bound of about 19 s, on #424 and on its rerun.drivine4j#609 found the cause, a second one under #420. The compiled CALL joins its one-row list (
jsonb_array_elements(cy_rows)) to the node table for each row. Postgres estimates the list at 100 rows and may pick a hash join over a scan of every node.This marks that one case, Postgres CALL…RETURN only, as a non-strict xfail citing #420, the same way the MERGE case is marked. The port of drivine4j#609's fix takes both marks off.
Gate
unasync --check: clean.