Conversation
ronnix
added a commit
to Delegation-numerique-en-sante/mesconseilscovid
that referenced
this pull request
Sep 14, 2021
ronnix
added a commit
to Delegation-numerique-en-sante/mesconseilscovid
that referenced
this pull request
Sep 14, 2021
ronnix
added a commit
to Delegation-numerique-en-sante/mesconseilscovid
that referenced
this pull request
Sep 14, 2021
tuanchauict
reviewed
Jun 3, 2023
| func = item['func'] | ||
| delay = item['delay'] | ||
| if delay and isinstance(delay, float): | ||
| if delay and isinstance(delay, float) or delay == 'forever': |
There was a problem hiding this comment.
Not related to this PR but seems like we should also fix isinstance(delay, float) to isinstance(10, (int, float)).
What do you think?
johbo
added a commit
to johbo/python-livereload
that referenced
this pull request
Sep 20, 2026
The sentinel was filtered out by the isinstance check that collects numeric delays, so it never reached poll_tasks and a watch asking not to reload the browser still reloaded it. Based on lepture#253, keeping the sentinel out of the numeric set so that max() never sees a string.
johbo
added a commit
to johbo/python-livereload
that referenced
this pull request
Sep 20, 2026
The sentinel was filtered out by the isinstance check that collects numeric delays, so it never reached poll_tasks and a watch asking not to reload the browser still reloaded it. Based on lepture#253, keeping the sentinel out of the numeric set so that max() never sees a string.
johbo
added a commit
to johbo/python-livereload
that referenced
this pull request
Sep 20, 2026
The sentinel was filtered out by the isinstance check that collects numeric delays, so it never reached poll_tasks and a watch asking not to reload the browser still reloaded it. Based on lepture#253, keeping the sentinel out of the numeric set so that max() never sees a string.
|
Did land here when trying to investigate why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on the work in #236 and avoids comparing strings and floats when computing the max delay.