feat(adapter): maxAdapter, cli-messaging's port over a connected MaxClient - #259
Merged
Merged
Conversation
…lient T6 item 4. MessengerCore plus MessageEditing, MessagePins, MessageReactions and ReadState, over a MaxClient built without its send guard: the shared services guard each write. Messages and attachments map to the shared shapes; MAX's file and video ids, control events and polls go under providerRef. MaxClient gains newSendId() (its timestamp cid, as the official client sends) and two send options the shared services need: uploads already read, and markup already parsed, in MAX's names. cli-messaging 0.64.0 for the port's newSendId. A send id that is not a safe integer is refused before anything is sent. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T6 item 4 (plan
docs_ai/plans/2026-09-30-max-onto-services.md, corrected as built).src/adapter/max-adapter.ts:MessengerCore+MessageEditing,MessagePins,MessageReactions,ReadStateover a connectedMaxClientbuilt without its guard (the shared services guard). Other groups join with their moves.MaxClient.newSendId()(timestampcid, as the official client) through cli-messaging 0.64.0'snewSendIdport hook (RISK-74); a non-safe-integer id is refused before sending.MaxClient.messages.sendgainsuploads(bytes already read) andmarkup(already parsed, MAX names).fileId/videoId/event/userIds/poll→providerRef.Tests:
src/adapter/max-adapter.test.tsagainst the mock MAX (frames sent, answers equal toMaxClient's mapped). Checked: lint, typecheck, 1176 tests, test:matrix, docs:check.🤖 Generated with Claude Code