Repository navigation
feat: Advertise post and report capabilities in SSE contract test service - #149
Merged
Merged
Conversation
The service has always fully wired the method/body parameters (mapped to ClientBuilder method/body options), but never advertised the "post" and "report" capabilities, so the SSE contract test suite's POST/REPORT tests and the request-body-resend-on-reconnect test silently skipped. Verified: with the strings added, the full contract test suite passes, including the newly unlocked tests. Generated-by: termag
kinyoklion
marked this pull request as ready for review
October 30, 2026 23:23
joker23
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
"post"and"report"to the capabilities the contract-test service advertises incontract-tests/src/bin/sse-test-api/main.rs.Why
A capability audit of the SSE contract-test services (write-up) found the service already fully wires the harness's
method/bodyparams (stream_entity.rs maps them to the client's method/body builder options) but never advertises the capabilities, so these suite tests were silently skipping:HTTP behavior/POST requestHTTP behavior/REPORT requestreconnection/resends request body if any when reconnectingHow verified
Ran the full sse-contract-tests harness locally (harness @ main + pending regression tests) against the rebuilt service on linux/arm64: all tests pass, including the newly unlocked ones.
Draft for review of the approach; one-line-per-capability change.
Opened from termag
SDK-3420
Note
Overview
The SSE contract-test service
statusresponse now includespostandreportin its advertisedcapabilitieslist.That aligns the harness with behavior already implemented via
Configmethod/body(andStreamEntity), so suite cases for POST/REPORT HTTP behavior and reconnection request-body resend are no longer skipped for lack of capability flags.Reviewed by Cursor Bugbot for commit cddc1b2. Bugbot is set up for automated code reviews on this repo. Configure here.