fix: Log the cached-data evaluation warning only once per client - #520
Draft
kinyoklion wants to merge 1 commit into
Draft
fix: Log the cached-data evaluation warning only once per client#520kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When data availability is CACHED, every evaluation and every all_flags_state() call logs a warning that the client is using last known values from the feature store. While the client stays in that state, this floods the log with one line per evaluation.
Each of these messages now logs once per client instance. LDClient and AsyncLDClient each hold two flags, one for the evaluation message and one for the all_flags_state() message. The messages say that they are logged once.
In LDClient, a threading.Lock guards the set of each flag. The lock is reached only inside the CACHED branch and only until the flag is set, so the normal evaluation path never touches it. Python has no lock-free atomic flag in the standard library. In AsyncLDClient, a plain boolean is enough because one event loop runs the client and no await separates the check and the set.
The sibling messages for the DEFAULTS case and the availability check itself are unchanged.