Conversation
beekld
added this pull request to stack #608
September 11, 2026 18:04
beekld
force-pushed
the
bklimt/SDK-3031/client-fdv2-streaming
branch
from
September 11, 2026 21:23
fbb9f5d to
99ba021
Compare
beekld
marked this pull request as ready for review
September 11, 2026 21:49
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9c5c071. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Adds the client SDK's FDv2 streaming synchronizer.
Implemented here:
FDv2ProtocolHandlerinto source results.goodbyeandpinghandling, and response-header parsing.InterruptedandTerminalError.Differences from the Android and Flutter clients:
Note
Overview
Adds
FDv2StreamingSynchronizerto the client SDK so FDv2 flag updates can stay current over a long-lived SSE connection, exposed through the sameIFDv2Synchronizer::Next()pull interface as polling.The synchronizer builds
/sdk/stream/evalrequests (GET with base64 context in the path or POST with JSON body), appliesbasisfrom the latest selector on each connect, and drivesFDv2ProtocolHandlerto emitChangeSet,Goodbye,Interrupted, andTerminalErrorresults.pingevents trigger a follow-up poll (overlapping pings are dropped while a poll is in flight). Response headers and goodbye payloads surface environment id and FDv1 fallback directives, with stream-level TTL overriding headers.Also adds a
ReadFDv2ResponseHeadersoverload for Boost.Beast response headers, linkslaunchdarkly::ssein client SDK tests, adds broad unit coverage via a test peer, tweaks server-sdk test mocks/formatting, and makes SSE read timeout log messages omit the duration when no timeout value is present.Reviewed by Cursor Bugbot for commit bd73ba9. Bugbot is set up for automated code reviews on this repo. Configure here.