ci: use the floating contract-tests-v1 tag for the contract tests action - #605
Merged
Merged
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Member
Author
|
We don't need to pin the internal actions, and dependabot was updating the pin incorrectly. So it will now float on v1. |
kinyoklion
marked this pull request as ready for review
September 9, 2026 15:51
beekld
approved these changes
Sep 9, 2026
beekld
left a comment
Contributor
There was a problem hiding this comment.
Kinda confusing that it's "v1" of the GH Action, even when it's "v3" of the actual contract tests. But this is clearly an improvement anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Point every
launchdarkly/gh-actions/actions/contract-testsusage at the floatingcontract-tests-v1tag instead of a SHA pin, and drop the now-redundant release-link comments.5adb11f/v1.3.0 →2715574/v1.1.0, which silently drops theenable_persistence_testsinput). Closed that PR; the floating tag stops the bad suggestions.client.yml,server.yml,sse.ymlwere still on v1.1.0 and effectively move to v1.3.0.sse.ymlsetsenable_persistence_tests: false— the sse-contract-tests harness has no-enable-persistence-testsflag and exits 2 when passed it (v1.3.0 defaults the input to true).Implementation details
contract-tests-v1is force-updated to each new release by gh-actions' release-please workflow, so it currently points at5adb11f(contract-tests-v1.3.0).v1.3.0 vs v1.1.0 for the workflows that were behind:
enable_persistence_tests(defaulttrue) → harness gets-enable-persistence-tests. Handled for SSE as above; for the server jobs the test service only advertisespersistent-data-store-{redis,dynamodb}when built withuse_redis/use_dynamodb, which those jobs don't do, so no additional suites run there.stop_service(defaulttrue), matching v1.1.0's hardcoded-stop-service-at-end.Tradeoff: a floating tag is mutable, so this gives up SHA pinning for this first-party action.
Link to Devin session: https://app.devin.ai/sessions/01bce0d0f3894fccba4fe3fc117ff8b1
Open in Devin Desktop: https://app.devin.ai/desktop/session/01bce0d0f3894fccba4fe3fc117ff8b1?variant=devin
Requested by: @kinyoklion
Note
Overview
Switches all contract-test CI jobs to the floating
contract-tests-v1ref onlaunchdarkly/gh-actions/actions/contract-testsinstead of mixed SHA pins (v1.1.0 / v1.3.0), and removes the redundant release-link comments above those steps.Workflows that were still on v1.1.0 (client, server, sse) effectively pick up v1.3.0 behavior via the tag. sse.yml explicitly sets
enable_persistence_tests: falseon both contract-test jobs so the harness is not passed-enable-persistence-tests(unsupported for SSE; v1.3.0 defaults that input to true). Redis/DynamoDB server jobs keepenable_persistence_tests: true; only the action ref changes there.Tradeoff: the floating tag is mutable, so SHA pinning for this first-party action is dropped in favor of simpler Dependabot/version alignment.
Reviewed by Cursor Bugbot for commit b674b86. Bugbot is set up for automated code reviews on this repo. Configure here.