Skip to content

ci: use the floating contract-tests-v1 tag for the contract tests action - #605

Merged
kinyoklion merged 2 commits into
mainfrom
devin/1788907678-contract-tests-floating-tag
Sep 9, 2026
Merged

kinyoklion merged 2 commits into
mainfrom
devin/1788907678-contract-tests-floating-tag

Conversation

@kinyoklion

@kinyoklion kinyoklion commented Sep 8, 2026

Copy link
Copy Markdown
Member

Summary

Point every launchdarkly/gh-actions/actions/contract-tests usage at the floating contract-tests-v1 tag instead of a SHA pin, and drop the now-redundant release-link comments.

Implementation details

contract-tests-v1 is force-updated to each new release by gh-actions' release-please workflow, so it currently points at 5adb11f (contract-tests-v1.3.0).

v1.3.0 vs v1.1.0 for the workflows that were behind:

  • adds enable_persistence_tests (default true) → harness gets -enable-persistence-tests. Handled for SSE as above; for the server jobs the test service only advertises persistent-data-store-{redis,dynamodb} when built with use_redis/use_dynamodb, which those jobs don't do, so no additional suites run there.
  • adds stop_service (default true), matching v1.1.0's hardcoded -stop-service-at-end.

Tradeoff: a floating tag is mutable, so this gives up SHA pinning for this first-party action.

Link to Devin session: https://app.devin.ai/sessions/01bce0d0f3894fccba4fe3fc117ff8b1
Open in Devin Desktop: https://app.devin.ai/desktop/session/01bce0d0f3894fccba4fe3fc117ff8b1?variant=devin
Requested by: @kinyoklion


Note

Overview
Switches all contract-test CI jobs to the floating contract-tests-v1 ref on launchdarkly/gh-actions/actions/contract-tests instead of mixed SHA pins (v1.1.0 / v1.3.0), and removes the redundant release-link comments above those steps.

Workflows that were still on v1.1.0 (client, server, sse) effectively pick up v1.3.0 behavior via the tag. sse.yml explicitly sets enable_persistence_tests: false on both contract-test jobs so the harness is not passed -enable-persistence-tests (unsupported for SSE; v1.3.0 defaults that input to true). Redis/DynamoDB server jobs keep enable_persistence_tests: true; only the action ref changes there.

Tradeoff: the floating tag is mutable, so SHA pinning for this first-party action is dropped in favor of simpler Dependabot/version alignment.

Reviewed by Cursor Bugbot for commit b674b86. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
@kinyoklion

Copy link
Copy Markdown
Member Author

We don't need to pin the internal actions, and dependabot was updating the pin incorrectly. So it will now float on v1.

@kinyoklion
kinyoklion marked this pull request as ready for review September 9, 2026 15:51
@kinyoklion
kinyoklion requested a review from a team as a code owner September 9, 2026 15:51

@beekld beekld left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda confusing that it's "v1" of the GH Action, even when it's "v3" of the actual contract tests. But this is clearly an improvement anyway.

@kinyoklion
kinyoklion merged commit 35d06fd into main Sep 9, 2026
55 checks passed
@kinyoklion
kinyoklion deleted the devin/1788907678-contract-tests-floating-tag branch September 9, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants