Repository navigation
fix(index): continue coreset splits and stabilize PQ smoke test - #10270
Merged
Merged
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Xuanwo
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two independent recall failures seen on main:
test_legacy_ivf_pq_cosine_multivec_smokeeight PQ sub-vectors instead of four, reducing quantization error with its small training sample. Keep its data, query, training sample rate, iteration count, andrecall >= 0.5assertion unchanged.Failing CI: Float64 streaming coreset recall, legacy multivector PQ recall.
Related: #9346 proposes fallback bisection and rejecting unattainable partition counts. This PR fixes singleton termination in the existing split loop and preserves the current exhausted-split behavior.
Validation
cargo fmt --all --checkcargo clippy --locked --all --tests --benches -- -D warningsgit diff --check; commit hooks pass.Local recall checks were measured on fix commit
271c19a82f6b8a7c2cd9574aca3a9bb8198f664cagainst77b7fd4250e248cce207c54389b7f7065f5252d9, before syncing main, on Apple M3 Max (arm64), Rust 1.98.1, default features and test profile. Each version uses the same seeded fixture; training runs use normal OS randomness and are independent.271c19a82Streaming: 600 Float64 vectors, four dimensions, two fragments, 257 partitions, sample rates 2/1, one training iteration, minimum 16 probes, query row 321. All-partition recall is 1.0 in every run before and after.
Multivector PQ: 200 runs per version, 512 rows with three 32-dimensional vectors each, one fully probed partition, query row 0, 8-bit codebooks, sample rate 1, two iterations. The Linux CI failure was 0.49; the local baseline did not fall below 0.5. These are fixture-specific correctness observations.
CI on
271c19a82passed Rust tests on all platforms, Clippy, Python and JNI checks. Its only failed check was the main-branch dependency advisory RUSTSEC-2026-0385. Syncing main incorporates the already-merged handling in #10269. The merged tree was rechecked with formatting, full workspace Clippy, and all 44 focused tests above; new CI results are pending.