Repository navigation
Offer only the visibility stops the tenant can honour at setup - #1940
Draft
realtonyyoung wants to merge 3 commits into
Draft
realtonyyoung wants to merge 3 commits into
realtonyyoung wants to merge 3 commits into
Conversation
Only the server knows whether an org stop grants more than a project one; a server without the read keeps every stop and org_public Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
A second visit after a failed harness check reads the offer again, and an answer picked from the earlier list would otherwise be saved Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No GitHub issue — AI-2896
What & why
kcap setup's visibility prompt offered all four stops on every tenant and preselectedorg_public, which on a tenant with no auto-public owner grants only whatprojectdoes. Setup and the desktop app's visibility step now readGET /api/users/me/visibility-options(kurrent-io/kcap-server#2674) and offer exactly its stops, in its order and with the browser flow's copy. The terminal prompt preselects the server's default, and--no-promptwithout--default-visibilitytakes it. A 404, or any other miss, keeps today's four stops andorg_public, and every miss other than a 404 leaves one line saying why. Existing profiles are not touchedWhere to look
--no-promptwithout--default-visibilitynow takes the server's default rather thanorg_public, so on a tenant with no auto-public owner a scripted setup stampsprojectorprivate, which is narrower. The README andkcap setup --helpsay soThe desktop step clears an answer a refreshed offer no longer makes, so a revisit cannot save it. The desktop step still makes the user pick before continuing rather than preselecting the server's default, because that explicit choice is pinned by
Privacy_requires_an_explicit_choice_before_install_or_skip. Preselecting there is a one-line change if wanted. The read ignores the response'sowners, since the org label already names themVerification
ServerVisibilityOptionsTests(Cli.Core, against WireMock): the three option sets, an unknown key dropped, an unoffered default, malformed JSON, 404 (silent), 401, 500 and an unreachable server, none of which throwsStep_three_offers_what_the_tenant_can_honour: red when the server's offer is ignored,Expected to be equivalent to [private, project, public]HandleAsync_NoPrompt_without_a_visibility_takes_the_servers_default(whole wizard against WireMock): red with the hard-coded default,Expected to be equal to "project", and the 404 and 500 rows keeporg_publicWho_can_read_offers_what_the_tenant_can_honour(desktop view-model): red when the offer is not applied,Expected to be equivalent to [private, public]. A failed or absent read keeps every answer, and a local install asks nothingdotnet publishof the CLI raised no AOT warnings🤖 Generated with Claude Code