Skip to content

Add prow presubmits for sig-security srctl tool - #37601

Open
iho wants to merge 1 commit into
kubernetes:masterfrom
iho:add-srctl-prow-jobs
Open

Add prow presubmits for sig-security srctl tool#37601
iho wants to merge 1 commit into
kubernetes:masterfrom
iho:add-srctl-prow-jobs

Conversation

@iho

@iho iho commented Aug 2, 2026

Copy link
Copy Markdown

WARNING! AI assisted PR

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds presubmit jobs for kubernetes/sig-security that run when sig-security-tooling/srctl changes:

  1. pull-sig-security-srctl-unit-testsgo test -v -cover ./... (kubekins image)
  2. pull-sig-security-srctl-golangci-lintgolangci-lint run ./... (golangci-lint v2.12.1, matches the project's golangci v2 config)

Pattern mirrors the existing cve-feed-tests.yaml presubmit. Also registers a sig-security-srctl Testgrid dashboard under the sig-security group.

Verified locally:

  • go test -v -cover ./... passes
  • golangci-lint v2.12.1 reports 0 issues

Which issue(s) this PR fixes:

Fixes kubernetes/sig-security#175

Special notes for your reviewer:

/sig security
/sig testing

Does this PR introduce a user-facing change?

NONE

Run unit tests and golangci-lint when PRs touch
sig-security-tooling/srctl, mirroring the cve-feed job pattern.

Also register a sig-security-srctl Testgrid dashboard.
@kubernetes-prow kubernetes-prow Bot added kind/feature Categorizes issue or PR as related to a new feature. sig/security Categorizes an issue or PR as relevant to SIG Security. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 2, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iho
Once this PR has been reviewed and has the lgtm label, please assign tabbysable for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot requested a review from IanColdwater August 2, 2026 20:24
@kubernetes-prow kubernetes-prow Bot added the area/config Issues or PRs related to code in /config label Aug 2, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from tabbysable August 2, 2026 20:24
@kubernetes-prow kubernetes-prow Bot added area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 2, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @iho!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 2, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @iho. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/security Categorizes an issue or PR as relevant to SIG Security. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tooling: run tests and linters with prow for srctl

1 participant