Prow presubmit unit tests - #37536
Conversation
kubernetes-prow
Bot
added
the
cncf-cla: yes
|
Welcome @alexatakvelon! |
|
Hi @alexatakvelon. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kubernetes-prow
Bot
added
size/L
kubernetes-prow
Bot
added
area/config
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alexatakvelon The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
needs-rebase
Registers presubmit-agent-sandbox-python-runtime-sandbox-test, mirroring the gemini-cu-sandbox job: builds the sandbox-runtime image in kind and runs its unit tests plus the existing e2e tester.
Registers three unit-tests-only presubmits (no kind cluster/docker build): presubmit-agent-sandbox-mcp-server-sandbox-test, presubmit-agent-sandbox-analytics-tool-test, and presubmit-agent-sandbox-langchain-test.
0a3dacf to
22dca5d
Compare
kubernetes-prow
Bot
removed
the
needs-rebase
kubernetes-sigs/agent-sandbox#1273 renamed test-gemini-cu-sandbox and test-python-runtime-sandbox to test-e2e-gemini-cu-sandbox / test-e2e-python-runtime-sandbox so generate_jobs.py's is_e2e() name matching (and any future regeneration) picks up the privileged DinD profile these jobs need. Update run_if_changed and command to match.
1 participant
Registers five new presubmits for kubernetes-sigs/agent-sandbox, generated by
generate_jobs.pyfrom the matchingdev/ci/presubmits/*scripts (companion PR: kubernetes-sigs/agent-sandbox#1273):presubmit-agent-sandbox-test-gemini-cu-sandboxpresubmit-agent-sandbox-test-python-runtime-sandboxpresubmit-agent-sandbox-test-mcp-server-sandboxpresubmit-agent-sandbox-test-analytics-toolpresubmit-agent-sandbox-test-langchainGenerator change:
test-gemini-cu-sandboxandtest-python-runtime-sandboxbuild a runtime image and load it into a kind cluster, but their names don't contain "e2e" or "benchmark", sogenerate_jobs.py's naming heuristic would otherwise classify them as plain unprivileged jobs. Added an explicitE2E_PRESUBMITSallowlist so the generator gives them the privileged kind/docker profile. The other three are genuinely unit-tests-only and correctly fall through to the default local-test profile without any override.Why this is a hand-splice, not a full regen: the five new entries were produced by running
generate_jobs.pyagainst an agent-sandbox checkout containing the new scripts, then added to the current config by hand rather than committing a full regeneration. A full regen right now would have (a) rolled back the image tag on every existing job, since the generator's checked-inIMAGEconstant lags the tag already live in this file (autobumped separately), and (b) droppedpresubmit-agent-sandbox-test-e2e-scalability-kwok, which is intentionally staged ahead of kubernetes-sigs/agent-sandbox#1269 (still open) and doesn't correspond to a script in agent-sandboxmainyet. Both are pre-existing, unrelated conditions this PR leaves untouched — the diff here is purely additive.Merge order: hold until kubernetes-sigs/agent-sandbox#1273 merges, same as the pattern in #37499 — these presubmits reference scripts that need to exist on
mainfirst.