Repository navigation
Muxed pod exec websocket protocol - #1966
Merged
kubernetes-prow[bot] merged 2 commits intoOct 19, 2026
Merged
kubernetes-prow[bot] merged 2 commits into
kubernetes-prow[bot] merged 2 commits into
Conversation
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
kubernetes-prow
Bot
added
the
approved
kubernetes-prow
Bot
added
cncf-cla: yes
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix includes regression coverage, and static review identified no blocking issues; tests were not executed.
No open issues 🎉
What changed in this PR
Fixes #1946 by honoring pod exec WebSocket options and enabling close support when V5 is negotiated.
Changes:
- Forwards stream flags, protocol, and custom headers.
- Sets demuxer close support from the negotiated protocol.
- Adds regression tests for option forwarding, protocol fallback, and V4 defaults.
| File | Description |
|---|---|
| tests/KubernetesClient.Tests/KubernetesExecTests.cs | Tests forwarded options and protocol-dependent close support. |
| src/KubernetesClient/Kubernetes.WebSocket.cs | Forwards exec options and enables close support for V5. |
Review effort: Balanced
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
brendandburns
added
the
lgtm
Contributor
Author
|
Adding lgtm label based on typo above :) |
kubernetes-prow
Bot
merged commit Oct 19, 2026
6b8d575
into
kubernetes-client:master
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1946