Repository navigation
chore: bump vitest from 4.1.11 to 5.0.5 - #93
Conversation
|
Claude finished @dependabot[bot]'s task in 3m 22s —— View job Dependency review — vitest 4.1.11 → 5.0.5
Verdict: safe to merge. A major bump, but it lands on the part of vitest this repo barely touches. One doc follow-up, no blockers. What actually changed
Lockfile: 11 packages removed, 2 added — net smaller tree. Vite itself only moves 8.2.2 → 8.3.4 (minor), not a Vite major. Why the blast radius is small here
Node floor: no change needed, but the rationale moved
What did change: the 22.12 dev floor now comes from vitest's own
|
#96) ## Why `npm audit --omit=dev` reports 8 advisories (1 critical, 3 high) in the locked runtime dependencies. This lockfile is what the `.mcpb` bundle installs from (`pack-mcpb.sh` copies it before `npm install --omit=dev`), so that's where users get them, along with CI and any scan of the repo. The npm package doesn't ship a lockfile, so `npx` users already resolve current versions within the SDK's ranges. All of them come in indirectly through `@modelcontextprotocol/sdk`: | Package | Before → after | Pulled in by | |---|---|---| | `proxy-addr` (critical) | 2.0.7 → 2.0.8 | express | | `hono` | 4.12.12 → 4.13.13 | SDK | | `@hono/node-server` | 1.19.13 → 2.1.5 | SDK (allows `^1.19.9 \|\| ^2.0.5`) | | `fast-uri` | 3.1.0 → 3.1.9 | ajv | | `ip-address`, `express-rate-limit` | 10.1.0 → 10.7.4, 8.3.2 → 8.7.1 | SDK | | `qs`, `body-parser` | 6.15.1 → 6.16.1, 2.2.2 → 2.4.0 | express | Most of these belong to the SDK's HTTP server transports, which this server doesn't use, since it only speaks stdio. Scanners still flag them in the release. Nothing would have fixed them otherwise. The weekly Dependabot version updates bump only direct dependencies, and Dependabot security updates were off. The repo also showed 0 Dependabot alerts, because the dependency graph was off. Both are being switched on in the repo settings. ## What `npm audit fix --omit=dev`. Only `package-lock.json` changes, and `package.json` is untouched. Every new version stays within the range its parent declares. The other lockfile changes (`content-type`, `type-is`, `iconv-lite`, `hasown`, `side-channel`, `es-object-atoms`) are patch or minor bumps that npm needed to resolve the fixed versions. ## Checked - `npm audit --omit=dev`: 0 vulnerabilities, down from 8. - `npm install --package-lock-only` leaves the lockfile unchanged, so it's consistent with `package.json`. - Locally: build, typecheck, 122 tests, and the smoke test against `dist/`. Before the rebase onto #79's merge commit I also ran it against the unzipped `.mcpb` (manifest validated). The bundle ships `@hono/node-server` 2.1.5. CI repeats all of this, plus the bundle on Node 22.0.0. ## Not in this PR - **Dev-only advisories (10).** They never ship. `@anthropic-ai/mcpb`'s `node-forge` and `tmp` have no fix yet. The `vite`/`vitest` ones should move with #93 (vitest 5). - **Declaring `zod` directly:** #95.
|
@dependabot rebase |
Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 4.1.11 to 5.0.5. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.5/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-version: 5.0.4 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
07182a8 to
0f5c198
Compare
| "tsx": "^4.19.0", | ||
| "typescript": "^5.7.0", | ||
| "vitest": "^4.1.10" | ||
| "vitest": "^5.0.5" |
There was a problem hiding this comment.
vitest 5 narrows its own engines.node from ^20.0.0 || ^22.0.0 || >=24.0.0 to ^22.12.0 || ^24.0.0 || >=26.0.0.
Nothing breaks — .nvmrc (22.12), the CI matrix (22.12, 24), update-catalog.yml (22.12) and release.yml (24) all satisfy it — but the reason for the 22.12 dev floor has moved. Two docs still attribute it to Vite transitively:
CLAUDE.md:44— "because vitest pulls Vite 8, which requires it"CONTRIBUTING.md:7— "vitest pulls Vite 8, which requires^20.19.0 || >=22.12.0"
Vitest now requires 22.12 directly, and its range also excludes Node 23 and 25 — so "≥ 22.12" is no longer the whole rule. Worth rewording so the next person moving the floor checks vitest's engines, not Vite's. (ci.yml:25-27 carries the same stale comment; I can't edit workflow files.)
Release prep for **0.6.0**. A draft for now: it gets rebased once #97 (CodeQL) merges, then marked ready. `npm version minor --no-git-tag-version` moves `package.json`, `package-lock.json` and the generated `src/version.ts` together. `manifest.json` gets the version at pack time. Nothing else changes. ## What's in 0.6.0 (since 0.5.0) ###⚠️ Changes that affect existing setups - **No configured org (#65).** `KOSLI_ORG` and the Desktop extension's *Organization* setting are removed. Every org-scoped call names its org through the execute tools' `org` input, so no request lands in an org the caller didn't name. An existing config that still sets `KOSLI_ORG` starts fine and logs that the value is ignored, but calls that relied on the default are now refused until an org is given. - **Node ≥ 22 (#38).** It was ≥ 20. ### Fixes - **Evidence downloads work again (#88, fixes #86).** Since 16 Oct, every `get_attestation_evidence` call failed: our token was forwarded to the pre-signed S3 URL. Text files come back as text, and binary files return a clear error. - **The `.mcpb` bundle starts on Node 22.0 – 22.6 (#87).** It didn't before. - **No known vulnerabilities in the bundled dependencies (#96).** `npm audit --omit=dev` is clean. ### Features - **`org` input on the execute tools (#65).** - **`User-Agent` carries the version (#41):** `kosli-mcp-server/<version>`. ### Dependencies - **Runtime:** `@modelcontextprotocol/sdk` 1.29.0 → 1.32.1 (#29, #71, #79). - **Dev:** TypeScript 7 (#45), with emitted output byte-identical to 5.9. vitest 5 (#93). - **Catalog:** regenerated from the OpenAPI spec (#50, #53, #60, #69, #78). ### Release confidence (CI only) Typecheck of tests and scripts, a stdio smoke test against `dist/` and the unzipped bundle (including Node 22.0.0), `mcpb validate`, and `release.yml` publishing only after every check (#87). There's also a phased Claude review (#90), Dependabot grouping with a 7-day cooldown, and CodeQL (#97). ## Checked locally on this branch - Build, typecheck, 122 tests. - The smoke test reports `server advertises version 0.6.0`, both from `dist/` and from the unzipped bundle. - `kosli-mcp-server-0.6.0.mcpb`: the manifest says 0.6.0 and `mcpb validate` passes. ## Before tagging (after merge) - [ ] Rebase onto `main` once #97 merges, then mark ready. - [ ] Install the 0.6.0 `.mcpb` in Claude Desktop, including an upgrade over 0.5.0 with an org configured. - [ ] Run `KOSLI_API_TOKEN=… KOSLI_SMOKE_ORG=<org> npm run smoke` on `main`. - [ ] Download one piece of evidence via `get_attestation_evidence`. - [ ] `git tag -a v0.6.0 -m "v0.6.0" <merge commit> && git push origin v0.6.0`. `release.yml` does the rest.
Bumps vitest from 4.1.11 to 5.0.5.
Release notes
Sourced from vitest's releases.
... (truncated)
Commits
7a825dbchore: release v5.0.5 (#11609)6621a72fix: abort all running tests on cancel (#11606)e9c3d72fix: release mocks of finished test files (#11607)8dd67c2fix(browser): run global setup once with instances (#11596)6c5a447fix: run hook cleanups when a later hook fails (#11605)9697b38fix: keep the import frame in native loader errors (#11599)6498b66fix(browser): wait 30s for the browser to close (#11601)f161e6dfix(browser): drop late connections of closed sessions (#11600)fe86a64fix: skip builtin loading in async leak detector (#11598)6ae8e89fix(reporter): end reason'failed'on worker crash (#11568)