Repository navigation
docs: make the cloud capture gcp tabs read standalone - #460
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
Claude finished @tooky's task in 2m 24s —— View job Follow-up review complete
ResultBoth previously raised findings are resolved:
Closed all 4 corresponding inline threads with confirmation. No new bugs, security issues, or regressions found in the newly changed lines (custom role permissions, Cloud Asset API enablement, the new AWS/GCP tenant-isolation tabs, and the restructured Full status posted as a summary comment. |
|
To answer a couple of the open questions- the Terraform code will not be prepopulated with the correct values; the values are visible in the Kosli UI only (in the new settings page). We have a new API endpoint for registering Cloud accounts, so they "let us know" by making f a POST request there |
|
@gsavage thanks. Both pages now say the inputs come from the Settings page and that you register the outputs through the cloud accounts endpoint. Is there an API reference link or example call I can add? |
Explain the GCP setup in GCP terms so a reader can follow the GCP tab without reading the AWS one. AWS comparisons stay as optional asides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cloud Capture reads GKE pods from Cloud Asset Inventory, as kosli snapshot gke does, not from each cluster's Kubernetes API. Remove the private control plane limitation and replace the Kubernetes API permissions with the Cloud Asset ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e read Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
24dec7d to
c6a5dfc
Compare
Follow-up review: previous findings vs. latest commitsChecked the three previous review threads against the newest commits (
No new bugs, security issues, or regressions found in the lines touched by these commits (GKE custom-role permissions, |
Summary
Until now, parts of the Cloud Capture GCP tabs only made sense if you'd already read the AWS tab. For example, the workload identity checks were defined as the "counterpart" of the AWS trust policy and external ID, and the setup steps said "GCP has no equivalent of phone-home". This PR rewrites the GCP content to explain each mechanism in GCP terms first. Where an AWS comparison still helps, it follows as a short optional aside. The AWS tab content is unchanged.
Security page
kosli_role_nameandattribute_conditioncomments in the Terraform are reworded the same way.kosli snapshot gkedoes. So:container.namespaces.*andcontainer.pods.*forcloudasset.assets.listContainerPodandserviceusage.services.usecloudasset.googleapis.comroles/cloudasset.viewer(which can also listk8s.io/Secret)Getting started page, GCP tab:
The overview's first step now says "Grant Kosli read-only access to your cloud accounts" rather than "Create an IAM role".
Still to do
The items below weren't confirmed when this PR opened, so the pages carry
{/* TODO */}comments for them. These are hidden on the rendered site.container.clusters.listandcontainer.clusters.get? If discovery also goes through Cloud Asset Inventory, those two permissions and the discovery comment in the role need changing.Also worth checking:
gcloud infra-manager deployments describeactually show Terraform outputs? They may only appear on the revision (gcloud infra-manager revisions describe, underapplyResults.outputs). The wording is unchanged from before, but it's now presented as a step users follow. Resolved: No. Both pages now userevisions describeon the latest revision.capture-managedorcloud-capture. Wherever the Settings-page download is generated, it needs the same changes: the reworded comments, the Cloud Asset permissions, and enabling the Cloud Asset API.Evidence
pytest tests/: 59 passed.mint dev: both pages render with the new tabs, steps and code blocks, and the TODO comments don't appear.mint broken-links: one broken link, intutorials/working_with_controls.mdx, which this PR doesn't touch.Merge Danger
Door: two-way. This is a docs-only change to two BETA pages and can be reverted cleanly.
Blast Radius: two pages under Administration ▸ Cloud Capture. No navigation, redirect or anchor changes. Customers who already followed the old GKE permissions would have a role without the Cloud Asset permissions, but GCP support is still marked "coming soon".
🤖 Generated with Claude Code