Conversation
The restore-on-launch modal swallowed left clicks with no hit-testing at all, so its Restore/Start fresh/Older buttons and the Older list rows only worked from the keyboard. Panel and button/row rects now come from one shared geometry helper in ember-render, consumed by both the draw and a new pure hit classifier, so the two can never drift. A click on a button or row focuses and activates it through the exact same action-construction methods Enter already uses; a click anywhere else stays a no-op since the modal is deliberate. Fixture renders before and after are byte-identical, and the new geometry/classifier unit tests plus the full workspace suite pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a v0.6.0 usability bug: the restore-on-launch prompt only answered to the keyboard. Its buttons (Restore / Start fresh / Older) and the Older archive rows now respond to mouse clicks.
460 tests green including 7 new geometry/classifier tests; clippy and fmt clean.
🤖 Generated with Claude Code