Conversation
saba8814
marked this pull request as draft
October 3, 2026 17:55
saba8814
force-pushed
the
test-syslog-capture
branch
from
October 3, 2026 17:57
f8d1146 to
d02b9db
Compare
This commit introduces a way for Infamy to log a marker on each DUT when a test attaches, and another
when the test exits. The syslog lines between the two are fetched
over SSH and saved next to the test output:
test/.log/<run>/output/0006-set-hostname.log
test/.log/<run>/syslog/0006-set-hostname-{target}.log
Each marker also carries
the host's wall-clock time, so DUT lines can be lined up with the
test output. Markers are only logged at test start and end to keep overhead down.
Capture is best-effort: if a DUT has rebooted or can't be reached, the
test gets a diagnostic comment and no syslog file. The test result is
never affected.
Resolves: #1608
Signed-off-by: Ejub Sabic <ejub1946@outlook.com>
Capturing syslog adds an SSH call per DUT when each test exits, and
most runs don't need the logs. Capture is now off unless enabled
with the new --capture-syslog Infamy argument, or with:
make TEST_SYSLOG_CAPTURE=y test
Signed-off-by: Ejub Sabic <ejub1946@outlook.com>
Explain what is saved, where the files end up, and how to enable it for make test and for interactive 9pm runs. Signed-off-by: Ejub Sabic <ejub1946@outlook.com>
Signed-off-by: Ejub Sabic <ejub1946@outlook.com>
saba8814
force-pushed
the
test-syslog-capture
branch
from
October 3, 2026 18:04
d02b9db to
fafe7e4
Compare
saba8814
changed the title
As discussed in #1608, DUTs now send their syslog to the test container instead of Infamy fetching it over SSH. Logs up to a crash or reboot are kept, and each test and DUT gets its own directory: test/.log/<run>/syslog/<test>/<dut>/syslog Test start and stop are marked with the log RPC, msgid test-start and test-stop. The container image gets sysklogd and is bumped to 2.15. Capture is still off by default. Signed-off-by: Ejub Sabic <ejub1946@outlook.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a way for Infamy to log a marker on each DUT when a test attaches, and another when the test exits. The syslog lines between the two are fetched
over SSH and saved next to the test output:
Each marker also carries the host's time, so DUT lines can be lined up with the
test output. Markers are only logged at test start and end to keep overhead down.
Capture is best-effort: if a DUT has rebooted or can't be reached, the
test gets a diagnostic comment and no syslog file. The test result is
never affected.
Checklist
Tick relevant boxes, this PR is-a or has-a: