WebUI fixes - #1677
Merged
Merged
WebUI fixes#1677
Conversation
Upload & Install failed on a Raspberry Pi with the nginx "device is starting" page in the progress card, after the upload had reached 100%. nginx spools the whole upload before handing it to the backend, and reading a bundle into a temp file on an SD card takes longer than the server's 15 s read timeout, so the connection closed and nginx answered 502. The handler also copied the spilled part once more into a second temp file, doubling the writes. Extend the request's own deadlines for the duration of the upload, and rename the spilled part into place instead of copying it. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
The dashboard showed the hostname template, e.g. "rpi-%m", since its system config fetch moved to the running datastore for the Software Updates card. Hostname, contact and location are resolved in the operational view, so read them from there as before and keep the running datastore for the card. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Contributor
Author
|
I've tested both of the fixes locally. |
mattiaswal
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes:
Checklist
Tick relevant boxes, this PR is-a or has-a: