Feat/2052/ab comparison custom filters - #2069
Merged
felipebergamin merged 5 commits intoSep 2, 2026
Merged
Conversation
felipebergamin
force-pushed
the
feat/2052/ab-comparison-custom-filters
branch
from
August 26, 2026 20:27
dec4bd4 to
b985a83
Compare
felipebergamin
marked this pull request as ready for review
August 27, 2026 19:05
alanpeixinho
approved these changes
Aug 31, 2026
alanpeixinho
left a comment
alanpeixinho
left a comment
Contributor
There was a problem hiding this comment.
Some small comments. Seems great.
| const isDuplicate = value.some(pair => pair.from === from && pair.to === to); | ||
| const canAdd = from !== undefined && to !== undefined && !isDuplicate; | ||
|
|
||
| const addPair = (): void => { |
Contributor
There was a problem hiding this comment.
nit: might be interesting to clear the from to dropdowns when adding.
| <div className="flex flex-col gap-3"> | ||
| <div className="text-dim-gray flex items-center gap-1 text-sm"> | ||
| <FormattedMessage id="filter.tableFilter" /> | ||
| <TooltipIcon |
Contributor
There was a problem hiding this comment.
do we still need a tooltip, now that the custom filters show the explicit rules?
Member
Author
There was a problem hiding this comment.
good point, I don't think so.
| } | ||
|
|
||
| /** Drop invalid/duplicate pairs; keep first-seen order. */ | ||
| export function normalizeStatusPairs( |
Contributor
There was a problem hiding this comment.
nit: cant we just expose parse and serialize, and just call those internally?
Ignore if it makes no sense.
| @@ -0,0 +1,134 @@ | |||
| import type { JSX } from 'react'; | |||
Contributor
There was a problem hiding this comment.
are those .stories. files running in prod?
Member
Author
There was a problem hiding this comment.
no, they are for storybook.
you can run storybook with pnpm storybook install and open http://localhost:6006/
you will see a like a demo for the components. But they run on dev env only.
felipebergamin
force-pushed
the
feat/2052/ab-comparison-custom-filters
branch
2 times, most recently
from
September 1, 2026 19:36
d27448a to
79ce986
Compare
…tories Introduce the From/To status pair form so Tree Compare can replace change-type chips with exact (from → to) filters, and expose it in Storybook for isolated UI review. Part of kernelci#2052 Signed-off-by: Felipe Bergamin <felipebergamin@profusion.mobi>
Replace URL change-type filters with exact From/To pairs, keep the old chips as shortcuts that add or remove those pairs, and persist the active list in the URL. Part of kernelci#2052 Signed-off-by: Felipe Bergamin <felipebergamin@profusion.mobi>
Use URL statusPair when present so shared links stay exact, and fall back to the last edited list in localStorage when the param is omitted. Closes kernelci#2052 Signed-off-by: Felipe Bergamin <felipebergamin@profusion.mobi>
Part of kernelci#2052 Signed-off-by: Felipe Bergamin <felipebergamin@profusion.mobi>
felipebergamin
force-pushed
the
feat/2052/ab-comparison-custom-filters
branch
from
September 2, 2026 18:03
79ce986 to
4ad2901
Compare
PASS→PASS was classified as newPass, so the New passes chip added it. Treat same-status pairs as unchanged except FAIL→FAIL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the free-form filters for AB Comparison page.
Visual reference
Gravacao_de_tela_20260825_174432.webm