Repository navigation
build: remove unused legacy docusaurus v1 dev dependency - #945
Open
Phantom-TA wants to merge 1 commit into
Open
Phantom-TA wants to merge 1 commit into
Phantom-TA wants to merge 1 commit into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
package.json still listed the Docusaurus v1 package ("docusaurus": "^1.14.7"),
left over from the Docusaurus v2 migration. The site builds with
@docusaurus/core 3.9.2 and nothing imports the v1 package.
It pulled in imagemin-gifsicle, so a plain `npm install` on Apple Silicon
failed while compiling gifsicle (autoreconf not available). With the
dependency gone the lockfile drops about 4,000 lines, `npm ls gifsicle
imagemin` is empty, and `npm run build` still succeeds.
Also note in the README that the yarn.lock makes Docusaurus call
`yarn --version`, so `npm run serve` and `npm run clear` fail on machines
without Yarn unless Yarn is installed or NO_UPDATE_NOTIFIER=1 is set.
Refs keploy/keploy#4820
Signed-off-by: Tushar <tushar08032005@gmail.com>
Phantom-TA
force-pushed
the
fix/remove-legacy-docusaurus-v1-dep
branch
from
October 29, 2026 07:21
4618983 to
17694f4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has changed?
Removes the unused legacy
docusaurusv1 dev dependency ("docusaurus": "^1.14.7") frompackage.jsonand regeneratesyarn.lock. It looks like a leftover from the Docusaurus v2 migration: the site builds with@docusaurus/core3.9.2 and nothing imports the v1 package.The v1 package pulled in
imagemin-gifsicle, so a plainnpm installon Apple Silicon failed while compilinggifsicle(autoreconfnot available). With it removed,npm ls gifsicle imageminis empty and the lockfile drops about 4,000 lines of entries that nothing needs. Kept packages did not change version; the only lockfile additions are mergedyarn.lockentries.I also added a short note to the README. The repo ships a
yarn.lock, so Docusaurus runsyarn --versionto suggest upgrade commands, andnpm run serve/npm run clearfail on machines without Yarn. I reproduced this locally. It comes from Docusaurus rather than from this repo, so the note says to install Yarn or setNO_UPDATE_NOTIFIER=1.This PR Resolves keploy/keploy#4820
Type of change
How Has This Been Tested?
Tested on Windows 11, Node v24.3.0, with the dependency removed:
yarn install(Yarn 1.22.22) regeneratedyarn.lock;patch-packageapplied cleanly.npm run buildsucceeds: client and server compile and all 209 documents are processed.npm ls gifsicle imageminshows an empty tree.npm run clearwithout Yarn installed reproduces theyarn --versionfailure described in the README note.npx prettier@2.8.8 --checkis clean on the changed files.I did not test on Apple Silicon myself; the
npm installfix was confirmed there by contributors in keploy/keploy#4820. I did not runnpm run serve, and I have not added screenshots.Checklist: