Repository navigation
feat(search): always show the preview, resizable results pane - #744
Merged
Merged
Conversation
The results list and the selected passage are now always side by side, in a split pane like the app's other panes, instead of the preview disappearing below a window width. The list's share of the width is kept across search tabs and restarts. Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnhancedHorizontalSplitPane, 5 dp grip, no visible line, the cards' gaps as dividers). Minimums: 380 dp for the list, 300 dp for the preview.search_list_split, not portable, as the docked panes' sizes).Test plan
compileKotlinJvm,detekt