Repository navigation
fix(error-report): open mailto links in the mail client, not the browser - #743
Merged
Merged
Conversation
On macOS and Windows, Desktop.browse hands any URI to the default browser, so the error-report mailto opened Chrome. Route mailto through Desktop.mail. Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS and Windows,
Desktop.browsehands any URI to the default browser, so the book error-reportmailto:opened Chrome instead of the mail client.UrlOpenernow routesmailto:URIs throughDesktop.mail(when supported); other URLs keepDesktop.browseand the existing command fallback.Compiles; not yet checked on a real macOS/Windows machine.