Repository navigation
fix(privacy): show update texts only where they apply - #742
Merged
Merged
Conversation
The conditions mention the polkit policy only when the install carries the passwordless update helper (signed deb/rpm), without naming Linux, and the startup update check only outside the Microsoft Store package, which the Store updates itself. The status block hides the update check checkbox there too. CONDITIONS.md marks those paragraphs with <!-- if:NAME --> blocks, which ConditionsText drops when they do not apply to this install. Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #741.
What changes
CONDITIONS.mdmarks those paragraphs with<!-- if:NAME -->…<!-- endif -->blocks.ConditionsTextdrops the ones that do not apply, through a newtransformparameter ofAccentMarkdownView.InstallInfoexposesselfUpdates(not AppX) andhasPasswordlessUpdateHelper.Testing
ConditionsTextTestcovers the block filter, plus the settings tests. detekt is clean.ExecutableRuntime.isAppX()andhasLinuxUpdateHelper(), which the update service already uses for these same cases.