Repository navigation
fix(generator): keep Otzaria links whose target Sefaria does not provide - #140
Merged
Merged
Conversation
Otzaria links were skipped for every book imported from Sefaria (#28), to drop the targum links that drifted a verse on differing headers. That also dropped links Sefaria has no equivalent for, like the 17,980 משנה ברורה → שער הציון links Otzaria aligned on the Sefaria text. Skip only links between two Sefaria books. This brings back ~23,900 links (שער הציון, תרגום ותפסיר רס"ג, ביאור הגר"א on the Zohar), checked against the current DB. Remove the unused processLinkFile duplicate. Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #28 the generator skips all Otzaria links of a book imported from Sefaria. The goal was to drop Otzaria targum links that drifted one verse (Bereshit → Onkelos, where the headers differ). But the rule only looks at the source book, so it also drops links Sefaria has no equivalent for.
The main loss is the 17,980 links משנה ברורה → שער הציון that Otzaria aligned on the Sefaria text (
tashmaToOtzaria/links/משנה ברורה_links.json). Because of this, שער הציון has 0 links in the DB.Fix
processLinkFile. It had no callers and duplicatedprocessLinksForBook.Links brought back
Counted on the link files of the current build:
Testing
:otzariasqlite:compileKotlinJvmand:otzariasqlite:jvmTestpass.generateLinkson a full build.