Repository navigation
fix(scenes): draw a preloading scene after a paused seek lands in it - #62
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
kino | 5a7a816 | Commit Preview URL Branch Preview URL |
Oct 11 2026, 05:36 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47.
When Stage draws scene 1 it preloads scene 2 with no
onDone. A paused seek into scene 2 while that preload is in flight calledensureLoaded(id, bump), which returned atpending.has(id)and dropped the callback. Paused, nothing else re-renders the stage, so it stayed empty (most often on?t=deep links).pendingis now a map of waiters per id: a caller asking for a scene already in flight joins the waiters, and every waiter runs when the load resolves.a seek into a scene still preloading draws it once the load lands(fails on main, passes here)🤖 Generated with Claude Code