Repository navigation
fix: keep looping animations moving between scenes - #60
Merged
Merged
Conversation
The scene clock stopped at the end of the narration. In the silence gap after it, every scene froze, so data moving between two boxes stopped until the next scene began. The clock now runs up to the scene's end. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
kino | 8f2ea0a | Commit Preview URL Branch Preview URL |
Oct 10 2026, 10:44 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Between two scenes there is a short silence gap. During that gap, the scene clock stopped at the end of the narration. So every animation froze, including looping ones like data moving from one box to another. The scene looked stuck until the next scene started.
The cause is
localTime: it stopped scene time ataudioDuration, not at the scene'send.What this PR changes
localTimeto stop atscene.end - scene.start, so the clock keeps running through the gap.audioDuration, and it still stops at the scene's end.protocol.ts, which said the scene holds still during the gap.Cue progress (
p,after,between) already stops at its end value. So anything driven by cues looks the same as before. Only animations that loop on the raw time keep moving.One thing changes for scenes: a scene that reads the raw time and does not limit it to
durationnow sees values pastdurationduring the gap.How I tested it
pnpm test: 267 tests pass.pnpm typecheckandpnpm lintpass.After release, I will bump kino in chiron and check the scene changes in a chiron guide in the browser.
🤖 Generated with Claude Code