Skip to content

feat(sputnik): Polyfills updated #2812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(sputnik): Polyfills updated #2812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/sputnik/src/js/apis/node/javy/text_encoding/polyfill.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,10 @@ fn decode(args: Args<'_>) -> Result<Value<'_>> {
.as_object()
.ok_or_else(|| anyhow!("buffer must be an object"))?
.as_array_buffer()
.ok_or_else(|| anyhow!("buffer must be an ArrayBuffer"))?
.as_bytes()
.ok_or_else(|| anyhow!("buffer must be an ArrayBuffer"))?;
// SAFETY: No JavaScript runs while the slice is alive; it is only read
// during UTF-8 decoding below.
let buffer = unsafe { buffer.as_bytes() }
.ok_or_else(|| anyhow!("Couldn't retrive &[u8] from buffer"))?;

let byte_offset = args[1]
Expand Down Expand Up @@ -108,4 +110,4 @@ fn encode(args: Args<'_>) -> Result<Value<'_>> {
Ok(TypedArray::new(cx, encoded.into_bytes())?
.as_value()
.to_owned())
}
}
Loading