Skip to content

feat: add server id to login command - #3394

Merged
RemiBou merged 1 commit into
jfrog:masterfrom
tim-goto:feature/tharing/server-id-for-login-command
Jun 9, 2026
Merged

RemiBou merged 1 commit into
jfrog:masterfrom
tim-goto:feature/tharing/server-id-for-login-command

Conversation

@tim-goto

Copy link
Copy Markdown
Contributor

this allows scripting the login without the modal prompt

merge after jfrog/jfrog-cli-core#1529

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

@tim-goto

Copy link
Copy Markdown
Contributor Author

@naveenku-jfrog can you also please take a look here? Our TSM is Douglas Hemsworth. Thanks!

@naveenku-jfrog

Copy link
Copy Markdown
Collaborator

Static Analysis Tests are failing. Please fix these tests first.

@tim-goto

Copy link
Copy Markdown
Contributor Author

thanks for taking the time to review, did you see what I wrote in the pr message?

merge after jfrog/jfrog-cli-core#1529

this needs the jfrog-cli-core changes to work

@RemiBou RemiBou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add tests

@tim-goto
tim-goto force-pushed the feature/tharing/server-id-for-login-command branch from c219c88 to 836859f Compare April 7, 2026 13:28
@tim-goto

tim-goto commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

thank you for reviewing this pr, I also added tests for my added lines. Again, this needs the jfrog-cli-core pr to be merged first.

@tim-goto
tim-goto requested a review from RemiBou April 7, 2026 13:29
@tim-goto

Copy link
Copy Markdown
Contributor Author

Hey @RemiBou would you mind reviewing again? Thanks!

@RemiBou RemiBou added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Apr 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@tim-goto
tim-goto force-pushed the feature/tharing/server-id-for-login-command branch from 836859f to 9267b5f Compare April 27, 2026 07:06
@tim-goto

Copy link
Copy Markdown
Contributor Author

I updated the jfrog-cli-core to include the required changes, please review/merge @RemiBou

@tim-goto
tim-goto force-pushed the feature/tharing/server-id-for-login-command branch from 9267b5f to 2062ab9 Compare May 8, 2026 08:33
@tim-goto

Copy link
Copy Markdown
Contributor Author

Hey @RemiBou , can we please move this forward? Thanks!

@RemiBou

RemiBou commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@tim-goto let me run CI and merge

@RemiBou
RemiBou force-pushed the feature/tharing/server-id-for-login-command branch from 2062ab9 to ae640ee Compare June 3, 2026 07:04
@RemiBou RemiBou added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Jun 3, 2026
@RemiBou
RemiBou force-pushed the feature/tharing/server-id-for-login-command branch from ae640ee to acc8f05 Compare June 5, 2026 08:16
@RemiBou
RemiBou enabled auto-merge (squash) June 5, 2026 08:16
@RemiBou RemiBou added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Jun 5, 2026
@RemiBou
RemiBou force-pushed the feature/tharing/server-id-for-login-command branch from acc8f05 to dfd8bdb Compare June 8, 2026 07:03
@RemiBou RemiBou added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Jun 8, 2026
@RemiBou
RemiBou disabled auto-merge June 8, 2026 14:14
this allows scripting the login without the modal prompt
@RemiBou
RemiBou force-pushed the feature/tharing/server-id-for-login-command branch from dfd8bdb to 772145d Compare June 8, 2026 14:14
@RemiBou RemiBou added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Jun 8, 2026
@RemiBou
RemiBou merged commit 2b851aa into jfrog:master Jun 9, 2026
87 of 88 checks passed
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
jfrog-cli 2.108.0

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>## What changed in v2.108.0

> Auto-generated from 6 repositories · 2026-06-11  
> Comparing `v2.107.0` → `v2.108.0`

> ℹ️  No changes in: gofrog

### ✨ New Features

- **[build-info-go]** Added pnpm package support to recognise 403 Forbidden output [#389](jfrog/build-info-go#389) (@Phavya-jfrog)
- **[jfrog-cli]** Add jf mcp command to configure the remote JFrog MCP server [#3533](jfrog/jfrog-cli#3533) (@ehl-jf)
- **[jfrog-cli]** Add AI context description to commands [#3503](jfrog/jfrog-cli#3503) (@ehl-jf)
- **[jfrog-cli]** feat: add server id to login command [#3394](jfrog/jfrog-cli#3394) (@tim-goto)
- **[jfrog-cli]** RTECO-1021 - Enhance metrics visibility by including package manager context [#3534](jfrog/jfrog-cli#3534) (@fluxxBot)
- **[jfrog-cli]** Make nix command visible [#3539](jfrog/jfrog-cli#3539) (@reshmifrog)
- **[jfrog-cli]** Added Post Failure Run support for pnpm and Yarn [#3509](jfrog/jfrog-cli#3509) (@Phavya-jfrog)
- **[jfrog-cli-artifactory]** JGC-473 - Add AI-agent help text to artifactory commands [#455](jfrog/jfrog-cli-artifactory#455) (@ehl-jf)
- **[jfrog-cli-artifactory]** RTECO-1021 - Enhance metrics visibility by including package manager context [#481](jfrog/jfrog-cli-artifactory#481) (@fluxxBot)
- **[jfrog-cli-artifactory]** RTECO-1400 - Add path validation to prevent traversal attacks in artifact handling [#487](jfrog/jfrog-cli-artifactory#487) (@fluxxBot)
- **[jfrog-cli-core]** RTECO-1021 - Enhance metrics visibility by including package manager context [#1569](jfrog/jfrog-cli-core#1569) (@fluxxBot)
- **[jfrog-cli-security]** Support parsing SCA issues without components [#758](jfrog/jfrog-cli-security#758) (@attiasas)
- **[jfrog-cli-security]** JGC-473 - Add AI-agent help text to security commands [#760](jfrog/jfrog-cli-security#760) (@ehl-jf)
- **[jfrog-cli-security]** Feature/xray 138688 add yarn support for jf ca [#759](jfrog/jfrog-cli-security#759) (@gauriy-tech)
- **[jfrog-cli-security]** XRAY-144809 - CA command [Maven]: Add option to consider plugin deps [#771](jfrog/jfrog-cli-security#771) (@gauriy-tech)
- **[jfrog-cli-security]** Feature/xray 138688 add pnpm support for jf ca [#769](jfrog/jfrog-cli-security#769) (@gauriy-tech)

### 🐛 Bug Fixes

- **[build-info-go]** RTECO-1287 jf poetry install --only main captures all dependency  [#391](jfrog/build-info-go#391) (@reshmifrog)
- **[jfrog-cli]** RTECO 1296 fix repeated 401 errors before fallback authentication [#3537](jfrog/jfrog-cli#3537) (@reshmifrog)
- **[jfrog-cli]** RTECO-1287 jf poetry install --only main captures all dependency  [#3530](jfrog/jfrog-cli#3530) (@reshmifrog)
- **[jfrog-cli-artifactory]** Updated logic for extracting repository key in case of reverse proxy scenario [#458](jfrog/jfrog-cli-artifactory#458) (@naveenku-jfrog)
- **[jfrog-cli-core]** Revert "Fix reference token privilege escalation" [#1571](jfrog/jfrog-cli-core#1571) (@reshmifrog)
- **[jfrog-cli-security]** XRAY-140212 - Updated gradle dep tree jar with the missing deps fix [#751](jfrog/jfrog-cli-security#751) (@gauriy-tech)
- **[jfrog-cli-security]** fix: disable npm workspaces for native config reads [#762](jfrog/jfrog-cli-security#762) (@omribz156)

### 📦 Other Changes

- **[build-info-go]** RTECO-1365 Include e2e tests from jfrog cli to build-info-go [#390](jfrog/build-info-go#390) (@reshmifrog)
- **[jfrog-cli-artifactory]** pnpm update error output handling [#465](jfrog/jfrog-cli-artifactory#465) (@Phavya-jfrog)
- **[jfrog-cli-security]** Auto install Cocoapods when Podfile.lock not exist [#723](jfrog/jfrog-cli-security#723) (@attiasas)
- **[jfrog-client-go]** Use Windows system certificate store for CLI TLS transport [#1351](jfrog/jfrog-client-go#1351) (@RemiBou)

---

### 📊 Summary

| Repository | Changes |
|---|---|
| [jfrog-cli](https://github.com/jfrog/jfrog-cli) | 8 |
| [jfrog-cli-security](https://github.com/jfrog/jfrog-cli-security) | 8 |
| [jfrog-cli-artifactory](https://github.com/jfrog/jfrog-cli-artifactory) | 5 |
| [build-info-go](https://github.com/jfrog/build-info-go) | 3 |
| [jfrog-cli-core](https://github.com/jfrog/jfrog-cli-core) | 2 |
| [jfrog-client-go](https://github.com/jfrog/jfrog-client-go) | 1 |
| **Total** | **27** |

### 🔗 Module Version Changes

| Module | From | To |
|---|---|---|
| [build-info-go](https://github.com/jfrog/build-info-go) | `v1.13.1-0.20260528065004-80409c046540` | `v1.13.1-0.20260610071651-260ad6720e0d` |
| [jfrog-cli-artifactory](https://github.com/jfrog/jfrog-cli-artifactory) | `v0.8.1-0.20260603105750-3886c0f01286` | `v0.8.1-0.20260610074911-82ce7d90edbd` |
| [jfrog-cli-core](https://github.com/jfrog/jfrog-cli-core) | `v2.60.1-0.20260601130310-8d52a530da18` | `v2.60.1-0.20260609101026-df3091b39d06` |
| [jfrog-cli-security](https://github.com/jfrog/jfrog-cli-security) | `v1.29.3` | `v1.30.0` |
| [jfrog-client-go](https://github.com/jfrog/jfrog-client-go) | `v1.55.1-0.20260528115006-6ca9682a3255` | `v1.55.1-0.20260603130552-af1dd449b994` |
</pre>
  <p>View the full release notes at <a href="https://github.com/jfrog/jfrog-cli/releases/tag/v2.108.0">https://github.com/jfrog/jfrog-cli/releases/tag/v2.108.0</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!11303

This branch had an error being deployed

1 failed deployment
frogbot — 772145d5 Deployed Jun 8, 2026 by RemiBou via scan-pull-request #4390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Approve running integration tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants