Skip to content

RTECO-0000 - Bump Go to 1.26.10 (eMudhra CA distrust) - #930

Closed
agrasth wants to merge 2 commits into
jfrog:mainfrom
agrasth:chore/go-1.26.10
Closed

agrasth wants to merge 2 commits into
jfrog:mainfrom
agrasth:chore/go-1.26.10

Conversation

@agrasth

@agrasth agrasth commented Oct 26, 2026 •

Copy link
Copy Markdown

Summary

Bump Go to 1.26.10. This release distrusts the compromised eMudhra CA certificates in the Go root store, which most other trust stores have already done.

Even though we don't serve TLS ourselves, the CLI and its libraries make outbound TLS connections, so we should build with the patched standard library.

Changes

  • go.mod: go 1.26.6 → 1.26.10

Validation (Go 1.26.10)

  • go build ./... and go vet ./... pass; go mod tidy produces no go.mod/go.sum changes beyond the version line.

  • Unit tests were run locally. Failures observed (missing local Artifactory on localhost:8083, local tool/env dependencies) reproduce identically on the unmodified base commit with its original Go version, so none are caused by this change.

  • The pull request is targeting the default branch.

  • The code has been validated to compile successfully by running go vet ./....

  • The code has been formatted properly using gofmt.

  • Full CI (incl. integration tests) still needs to run on this PR.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the project’s Go language version setting.
    • Refreshed the npm test project’s local service configuration. These maintenance changes support the project’s development and testing setup; no end-user-facing functionality changes are included in this update.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI; Enforced overrides: Organization, Workspace
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: b32bf65f-d02b-4213-8271-97ea930ebcf5
Commits

Reviewing files that changed from the base of the PR and between c91f2d7 and 335d8c9.

Files selected for processing: 2
  • go.mod
  • tests/testdata/projects/package-managers/npm/npm-project/.jfrog/jfrog-cli.conf.v6

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The Go version directive changes from 1.26.6 to 1.26.10. The npm test project adds a JFrog CLI v6 configuration with a default server, local service URLs, and credentials.

Changes: Go Version

Layer / File(s) Summary
Update Go version
go.mod
The Go version directive changes from 1.26.6 to 1.26.10.

npm Test Configuration

Layer / File(s) Summary
Add JFrog CLI server configuration
tests/testdata/projects/package-managers/npm/npm-project/.jfrog/jfrog-cli.conf.v6
The configuration defines a default server named test, local service URLs on port 62059, credentials, and version 6.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: attiasas

Merge Risk: Minimal · previous review 335d8

The changes are limited to the Go version update and isolated local test configuration, with no identified merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies the primary change: updating Go to 1.26.10 to address eMudhra CA distrust.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@agrasth agrasth added the dependencies Pull requests that update a dependency file label Oct 27, 2026
@agrasth agrasth closed this Oct 27, 2026

This branch is waiting to be deployed

1 waiting deployment
frogbot — b7360839 Waiting Oct 27, 2026 by agrasth via scan-pull-request #4736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant