Repository navigation
Expend vsc detection - #485
Merged
Merged
Conversation
attiasas
requested review from
a team,
agrasth,
bhanurp,
fluxxBot,
itsmeleela and
reshmifrog
June 7, 2026 11:37
reshmifrog
added
improvement
… in build-info Use GetCIVcsPropsString with cwd when dot-git-path is unset, and prefix artifact search patterns with */ when OriginalDeploymentRepo is missing so Gradle extractor build-info paths resolve during SetProps. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
agrasth
previously approved these changes
Jun 24, 2026
| // Fallback: path-only from build-info — use wildcard repo for search-based SetProps | ||
| if artifact.Path != "" { | ||
| return artifact.Path | ||
| return "*/" + strings.TrimPrefix(artifact.Path, "/") |
Collaborator
There was a problem hiding this comment.
When the Gradle extractor omits OriginalDeploymentRepo, the path */com/example/foo/1.0/foo.jar is used for SetItemProperties. Artifactory will match this pattern across all repos — local deployment repos, virtual repos that shadow the same path, remote repo caches, etc. This silently stamps VCS metadata on artifacts the user never intended to tag.
In practice this is mostly harmless (virtual repos are usually read-only for property writes), but if an org has a virtual repo backed by multiple locals and the same artifact was released at the same path in a different local repo, both get tagged.
We can look for a way to restrict the search to local repos only in the AQL or SetProps call when using */? If not, at minimum log a warning when the wildcard fallback is used.
Contributor
Author
There was a problem hiding this comment.
added a log and a call to get all local repositories
4 tasks
agrasth
approved these changes
Jul 1, 2026
reshmifrog
approved these changes
Jul 2, 2026
social4hyq
pushed a commit
to social4hyq/homebrew-core
that referenced
this pull request
Sep 20, 2026
jfrog-cli 2.113.0 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>## What changed in v2.113.0 > Auto-generated from 3 repositories · 2026-07-08 > Comparing `v2.112.0` → `v2.113.0` > ℹ️ No changes in: build-info-go, gofrog, jfrog-cli-core, jfrog-client-go ### ✨ New Features - **[jfrog-cli]** Rteco alpine tests [#3590](jfrog/jfrog-cli#3590) (@naveenku-jfrog) ### 🐛 Bug Fixes - **[jfrog-cli]** RTECO-945 - Fix Go version mismatch in Alpine APK CI [#3592](jfrog/jfrog-cli#3592) (@naveenku-jfrog) - **[jfrog-cli-artifactory]** RTECO-1560 - Fix agentplugins install issue [#500](jfrog/jfrog-cli-artifactory#500) (@udaykb2) - **[jfrog-cli-security]** XRAY-146567 - Fixed maven proxy issue [#796](jfrog/jfrog-cli-security#796) (@gauriy-tech) ### 📦 Other Changes - **[jfrog-cli]** RTECO-1560 - Skip agentplugins tests [#3587](jfrog/jfrog-cli#3587) (@udaykb2) - **[jfrog-cli]** Hide survey link when invoked by an AI agent [#3588](jfrog/jfrog-cli#3588) (@ehl-jf) - **[jfrog-cli-artifactory]** Expend vsc detection [#485](jfrog/jfrog-cli-artifactory#485) (@attiasas) - **[jfrog-cli-artifactory]** Expend vsc detection for container [#486](jfrog/jfrog-cli-artifactory#486) (@attiasas) - **[jfrog-cli-security]** Pass os env variables to SAST server [#790](jfrog/jfrog-cli-security#790) (@ilya-k-1) - **[jfrog-cli-security]** XRAY-145620 - Report actual module count in git audit config profile error [#793](jfrog/jfrog-cli-security#793) (@Jordanh1996) --- ### 📊 Summary | Repository | Changes | |---|---| | [jfrog-cli](https://github.com/jfrog/jfrog-cli) | 4 | | [jfrog-cli-artifactory](https://github.com/jfrog/jfrog-cli-artifactory) | 3 | | [jfrog-cli-security](https://github.com/jfrog/jfrog-cli-security) | 3 | | **Total** | **10** | ### 🔗 Module Version Changes | Module | From | To | |---|---|---| | [jfrog-cli-artifactory](https://github.com/jfrog/jfrog-cli-artifactory) | `v0.8.1-0.20260701085637-6ba50cd3676f` | `v0.8.1-0.20260708065639-7c53c506fbcf` | | [jfrog-cli-security](https://github.com/jfrog/jfrog-cli-security) | `v1.31.1` | `v1.31.2` | </pre> <p>View the full release notes at <a href="https://github.com/jfrog/jfrog-cli/releases/tag/v2.113.0">https://github.com/jfrog/jfrog-cli/releases/tag/v2.113.0</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!13802
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
Changes
rt upload(generic upload)rt bp(buildinfo publish)