Repository navigation
feat!: review follow-ups: main's Claude setup for branch sessions, Bun floor, one config read - #89
Merged
Merged
Conversation
…n floor, one config read
- A session in a branch's files (build, fix, verify, review, revise) no longer
loads the branch's own Claude Code setup. Its settings, CLAUDE.md, rules,
skills, agents, commands and MCP servers come from main's commit, written
into a per-session folder, so a build can't change what later sessions in
its step are told or allowed.
- A bare Bash rule (Bash, Bash(*)) is refused on every step and in
claude.allowed_tools, since it would let a session run any git.
- `start` and `upgrade` refuse a Bun older than engines.bun and say to run
`bun upgrade`. A canary counts as its release version.
- The Bun version lives only in .bun-version, which setup-bun reads; a test
keeps engines and the README in step. @types/bun goes to 1.4.4.
- A session reads the config once: model keys use the config its prompt was
rendered from.
- Shared helpers are deduplicated (readText, splitFrontmatter, TEAM_NAME,
ITEM_NAME, once, readBlobs, dropEmptyMaps). Removing a step's agent
settings no longer leaves `agents: {}` behind.
BREAKING CHANGE: a config whose claude.allowed_tools contains a bare Bash
rule (Bash or Bash(*)) now fails to load. Name the commands instead, like
Bash(make *).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the
/code-review high 88list (items 1–5), plus fixes from a second review of this work.What changes
BashorBash(*)would let a session run any git, so it's refused on every step's agent tools and inclaude.allowed_tools. Name the commands instead, likeBash(make *).loopstra startandloopstra upgraderefuse a Bun older thanengines.bunand say to runbun upgrade(upgrade --checkreports it and carries on). A canary counts as its release version..bun-versionholds it and everysetup-bunstep reads it (bun-version-file). A test keepsengines.bunand the README in step with it.@types/bungoes to 1.4.4.--setting-sources user(or""withsources: repo), so the branch's.claude/settings.json,.mcp.json, CLAUDE.md, rules, skills, agents and commands don't load. main's versions are read from main's commit, never from a checkout a session could write, into a temporary folder for each session:--settings;--add-dir;project;--mcp-config, leaving out any that settings disable.readText,splitFrontmatter,TEAM_NAME,ITEM_NAME,once,readBlobsanddropEmptyMaps. Removing a step's agent settings no longer leavesagents: {}behind.Breaking change
A config with a bare Bash rule in
claude.allowed_toolsnow fails to load.Known limits (in the README)
Testing
bun run check: 1851 pass, 0 fail; typecheck, lint and deadcode are clean.project:alpha), env and MCP server loaded;🤖 Generated with Claude Code