Skip to content

chore(renovate): hold argo-cd chart below 10.11.0 [OPS-303] - #534

Open
jdwlabs-agent-bot[bot] wants to merge 1 commit into
mainfrom
fix/OPS-303-hold-argo-cd-chart
Open

jdwlabs-agent-bot[bot] wants to merge 1 commit into
mainfrom
fix/OPS-303-hold-argo-cd-chart

Conversation

@jdwlabs-agent-bot

Copy link
Copy Markdown
Contributor

Why

Renovate would re-propose argo-cd chart 10.11.x, which ships the broken Argo CD v3.5.6 (OPS-303, reverted in #533).

Risk/rollout

risk/R3: touches gated renovate.json; CODEOWNERS approval needed. No cluster change.

Verified

  • Single rule added; JSON parses.

Chart 10.11.1 (Argo CD v3.5.6) crash-looped the repo-server, fixed by #533. This keeps Renovate from proposing it again.


Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Assisted-by: Claude Code:claude-sonnet-5-5
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jdwlabs-review-bot

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Version Hold Rule

The PR introduces a version hold rule for the 'argo-cd' chart to prevent it from updating to version 10.11.1 or higher, due to a known issue with Argo CD v3.5.6 causing the repo-server to crash-loop. This is a temporary measure to avoid breaking the system until a fixed version is available. While the rule itself is correctly implemented, it's important to track when this rule can be safely removed to allow future updates.

{
  "description": "Argo CD chart 10.11.1 (Argo CD v3.5.6) crash-loops the repo-server: the metrics port never binds and the probes kill the pod. Held below 10.11.0 until a chart with a fixed Argo CD ships; lift this rule then.",
  "matchPackageNames": ["argo-cd"],
  "allowedVersions": "<10.11.0"
},

@jdwlabs-review-bot

Copy link
Copy Markdown

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Pin the Argo CD version to avoid known crash-loop issue

Consider adding a more specific version constraint to ensure the rule targets the
problematic version exactly while allowing future safe updates.

renovate.json [11-15]

     {
       "description": "Argo CD chart 10.11.1 (Argo CD v3.5.6) crash-loops the repo-server: the metrics port never binds and the probes kill the pod. Held below 10.11.0 until a chart with a fixed Argo CD ships; lift this rule then.",
       "matchPackageNames": ["argo-cd"],
-      "allowedVersions": "<10.11.0"
+      "allowedVersions": "<10.11.0",
+      "matchCurrentVersion": "<10.11.0"
     }
Suggestion importance[1-10]: 3

__

Why: The suggestion proposes adding "matchCurrentVersion": "<10.11.0" to the rule, but this is not a meaningful improvement for the existing configuration. The rule already effectively prevents versions >= 10.11.0 through "allowedVersions": "<10.11.0". Adding matchCurrentVersion doesn't provide additional value and doesn't address any real issue in the current setup.

Low

@jdwillmsen jdwillmsen added risk/R2 merge-captain tag/deps merge-captain tag/platform merge-captain labels Oct 28, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review effort 2/5 risk/R2 merge-captain tag/deps merge-captain tag/platform merge-captain

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant