Skip to content

build(deps): patch Angular, Nx and x/net security alerts - #262

Merged
jdwillmsen merged 3 commits into
mainfrom
fix/dependabot-code-scanning-alerts
Oct 23, 2026
Merged

jdwillmsen merged 3 commits into
mainfrom
fix/dependabot-code-scanning-alerts

Conversation

@jdwlabs-agent-bot

Copy link
Copy Markdown
Contributor

Why
Clears the open Dependabot alerts (@angular/router x2 high, nx medium) and the actionable code-scanning alerts (x/net CVE-2026-78669/97032/78663/78660/78659, Trivy DS-0002).

Needs attention

  • package.json: @angular-devkit/build-angular and @angular/build stay at 22.2.3, not 22.2.4. 22.2.4 pins webpack 5.112.0, which fails all four module-federation production builds (Cannot find module .../extractUrlAndGlobal).
  • servicediscovery/go.mod: the go directive moved 1.25.0 to 1.26.0 (x/net requirement; matches go.work).
  • Not fixed, to be dismissed with justification: GO-2026-5932 (x/crypto openpgp, no fixed version, unused) and DS-0026 (distroless images have no shell or curl for a HEALTHCHECK; Kubernetes ignores it and uses probes).

Verified

  • nx affected -t lint test build: 78 tasks green
  • nx format:check: clean
  • go build and go test in servicediscovery

jdwlabs-agent-bot Bot and others added 3 commits October 23, 2026 21:14
Fixes the @angular/router and nx Dependabot alerts. build-angular and
build stay on 22.2.3: 22.2.4 requires webpack 5.112.0, whose
module-federation production builds fail.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Assisted-by: Claude-Code:claude-sonnet-5-5
Clears the five open x/net code-scanning alerts.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Assisted-by: Claude-Code:claude-sonnet-5-5
Trivy DS-0002 flagged the local image, which relied on the base tag's
default user.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Assisted-by: Claude-Code:claude-sonnet-5-5
@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: jdwlabs/apps
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: 804dba8
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7fd4bbf5-3163-47f1-94c5-5755c2c05ac8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jdwlabs-review-bot

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Dependency Version Bump

The update of golang.org/x/net from v0.58.0 to v0.60.0, along with golang.org/x/sys and golang.org/x/text, addresses several code-scanning alerts including CVE-2026-78669, CVE-2026-97032, CVE-2026-78663, CVE-2026-78660, and CVE-2026-78659. This is a security patch that should mitigate potential vulnerabilities in the network-related functionalities used by the service discovery component.

golang.org/x/net v0.60.0 // indirect
golang.org/x/sys v0.48.0 // indirect
golang.org/x/text v0.42.0 // indirect
Angular and Nx Version Updates

The Angular and Nx dependencies have been updated across various packages. While these updates address security concerns, it's important to ensure that all related components and configurations are compatible with the new versions. Specifically, the @angular/router dependency has been updated to version 22.2.3, which resolves high severity security alerts. It's crucial to verify that the application continues to function correctly after these updates.

"@angular-devkit/build-angular": "22.2.3",
"@angular-devkit/core": "22.2.4",
"@angular-devkit/schematics": "22.2.4",
"@angular-eslint/eslint-plugin": "22.2.0",
"@angular-eslint/eslint-plugin-template": "22.2.0",
"@angular-eslint/template-parser": "22.2.0",
"@angular/build": "22.2.3",
"@angular/cdk": "22.2.4",
"@angular/cli": "22.2.4",
"@angular/compiler-cli": "22.2.3",
"@angular/language-service": "22.2.3",
"@angular/material": "22.2.4",
"@commitlint/cli": "^21.0.0",
"@commitlint/config-conventional": "^21.0.0",
"@eslint/js": "10.0.1",
"@module-federation/enhanced": "^2.1.0",
"@nx-go/nx-go": "^4.0.0",
"@nx-tools/container-metadata": "^7.0.0",
"@nx-tools/nx-container": "^7.0.0",
"@nx/angular": "23.2.1",
"@nx/devkit": "23.2.1",
"@nx/eslint": "23.2.1",
"@nx/eslint-plugin": "23.2.1",
"@nx/gradle": "23.2.1",
"@nx/js": "23.2.1",
"@nx/module-federation": "23.2.1",
"@nx/playwright": "23.2.1",
"@nx/web": "23.2.1",
"@nx/webpack": "23.2.1",
"@nx/workspace": "23.2.1",

@jdwlabs-review-bot

Copy link
Copy Markdown

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Security
Patch Angular dependencies for security

Update Angular dependencies to patch version 22.2.3 to address potential security
vulnerabilities.

libs/frontend/shared/ui/package.json [6-9]

-    "@angular/common": "22.2.0",
-    "@angular/core": "22.2.0",
-    "@angular/material": "22.2.0",
-    "@angular/router": "22.2.0",
+    "@angular/common": "22.2.3",
+    "@angular/core": "22.2.3",
+    "@angular/material": "22.2.4",
+    "@angular/router": "22.2.3",
Suggestion importance[1-10]: 8

__

Why: This suggestion correctly identifies that updating Angular dependencies from version 22.2.0 to 22.2.3 (and related packages) can address potential security vulnerabilities. The improved code reflects the necessary version bumps, making it a moderately impactful improvement.

Medium
General
Use consistent user ID for container security

The numeric user ID 65532 is hardcoded and may not be consistent across
environments. Using a named user or ensuring the UID is properly managed in
Kubernetes contexts is recommended.

apps/backend/ai-sre-relay/Dockerfile [8-9]

+# Numeric uid: Kubernetes runAsNonRoot cannot verify a named user.
+USER 65532:65532
 
-
Suggestion importance[1-10]: 3

__

Why: The suggestion highlights that using a hardcoded numeric UID might cause inconsistency across environments, but the actual change proposed doesn't modify the existing code. The code already uses USER 65532:65532 which is the intended behavior for Kubernetes runAsNonRoot.

Low
Upgrade Go version and manage dependencies

Update the Go version to 1.26.0 and ensure all dependencies are compatible with this
version.

apps/backend/servicediscovery/go.mod [3-7]

+go 1.26.0
 
+require (
+	github.com/rs/cors v1.11.1
+	go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.71.0
+)
Suggestion importance[1-10]: 1

__

Why: The suggestion states to update the Go version to 1.26.0 and ensure compatibility, but the code already specifies go 1.26.0. There is no actual change needed, so the score is very low.

Low

@jdwillmsen jdwillmsen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the diff: Angular 22.2.3/22.2.4 and Nx 23.2.1 bumps (fixes the router and nx advisories), x/net 0.60.0 in servicediscovery, numeric USER in both ai-sre-relay Dockerfiles. Paths and versions are real, checks are green, and build-angular is deliberately held at 22.2.3 because 22.2.4 breaks the module-federation builds.

@jdwillmsen
jdwillmsen merged commit fa70f16 into main Oct 23, 2026
23 checks passed
@jdwillmsen
jdwillmsen deleted the fix/dependabot-code-scanning-alerts branch October 23, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant